[Fix] App image builds fail during npm publication races - #926
Draft
roomote-roomote[bot] wants to merge 1 commit into
Draft
[Fix] App image builds fail during npm publication races#926roomote-roomote[bot] wants to merge 1 commit into
roomote-roomote[bot] wants to merge 1 commit into
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
npm installresolution withnpm ci.Why this change was made
The app image previously resolved Snowflake's full transitive dependency tree from npm during every build. An upstream package publication race could therefore break otherwise unrelated image builds.
Impact
App image builds now use one reviewable, integrity-checked dependency tree and only change it when the committed lockfile changes. The locked install and repository checks pass locally; an end-to-end image build was unavailable in this sandbox because it does not expose a Docker socket, so CI remains the final image-build verification.