Skip to content

AUTH-005: return users to protected route after sign-in#97

Merged
daliu merged 1 commit into
mainfrom
codex/issue-96-login-return
Jul 12, 2026
Merged

AUTH-005: return users to protected route after sign-in#97
daliu merged 1 commit into
mainfrom
codex/issue-96-login-return

Conversation

@daliu

@daliu daliu commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Summary

  • preserve pathname, query, and hash when account/admin guards redirect to login
  • return successful sign-ins to the requested route, defaulting to /account
  • reject absolute, protocol-relative, backslash, control-character, malformed, encoded, and dot-segment-normalized unsafe targets
  • cover the real AdminGuard → login → authenticated-route round trip

Verification

  • CI=true npx -y node@20 ... react-scripts test src/pages/login/LoginForm.test.jsx --watchAll=false --runInBand — 15/15 pass
  • Node 20 production compile — pass
  • changed-file ESLint — 0 errors; 6 pre-existing warnings
  • Functions lint + tests under Node 20 — 2 suites / 7 tests pass
  • Firestore emulator rules under Node 20 — 4 suites / 97 tests pass
  • independent review by two agents — approved after normalization/query-hash findings were fixed

Known baseline

The repository-wide frontend run still fails in unchanged App.test.jsx before executing its test because TextEncoder is absent from the current setupTests.js. Another agent is already changing those overlapping harness files; #96 neither changes nor worsens that baseline.

Closes #96

@netlify

netlify Bot commented Jul 12, 2026

Copy link
Copy Markdown

Deploy Preview for luminous-fox-7c393f failed.

Name Link
🔨 Latest commit 1b5b5df
🔍 Latest deploy log https://app.netlify.com/projects/luminous-fox-7c393f/deploys/6a53f98d9ebc9300082052a5

@daliu daliu merged commit d26e002 into main Jul 12, 2026
3 of 7 checks passed
@daliu daliu deleted the codex/issue-96-login-return branch July 12, 2026 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant