pkcs5: add back support for using AES-GCM in PBES2#2313
Merged
Conversation
tarcieri
force-pushed
the
pkcs5/aes-gcm
branch
2 times, most recently
from
cb58469 to
340299c
Compare
tarcieri
changed the title
This reverts commit bdb62f4 (#2292) Support for AES-GCM was originally added to `pkcs5` in #1433 but was reverted because we wanted to cut a stable release of `pkcs5` before there was a stable release of `aes-gcm`. Now that `aes-gcm` v0.11 has been released (RustCrypto/AEADs#852) we can restore this functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This support was originally added in #1433, but reverted in #2292 to unblock a release of the
pkcs5crate until such time as there is a stable release ofaes-gcm.TODO: still pending a stable release ofEdit: released! RustCrypto/AEADs#852aes-gcm