Skip to content

fix(dom): break frame-loop closure Rc cycle in auto_update cleanup #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ademilsonfp wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −0
Open

fix(dom): break frame-loop closure Rc cycle in auto_update cleanup #357

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/dom/src/auto_update.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,6 +401,7 @@ pub fn auto_update(
let frame_loop_frame_id = frame_id.clone();
let frame_loop_closure = Rc::new(RefCell::new(None));
let frame_loop_closure_clone = frame_loop_closure.clone();
let frame_loop_closure_cleanup = frame_loop_closure.clone();

*frame_loop_closure_clone.borrow_mut() = Some(Closure::new({
let owned_reference = owned_reference.clone();
Expand Down Expand Up @@ -495,5 +496,7 @@ pub fn auto_update(
if let Some(frame_id) = frame_id.take() {
cancel_animation_frame(frame_id);
}

drop(frame_loop_closure_cleanup.borrow_mut().take());
})
}
Loading