Skip to content

Colour - #124

Open
tim-band wants to merge 7 commits into
mainfrom
colour
Open

Colour#124
tim-band wants to merge 7 commits into
mainfrom
colour

Conversation

@tim-band

Copy link
Copy Markdown
Collaborator

Fixes #121
Colours in configure-generators; it makes a huge difference!
We have three "themes"
dark for dark screens (bright colours for text -- this is the default)
light for light screens (dark colours for text)
none no colouring, just like we have now.

@@ -0,0 +1,206 @@
""" Tests for the configure-generators choice generators. """

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just pulled out of test_interactive_generators.py because pylint complained it got too big.

@tim-band
tim-band requested review from myyong and yhong123 July 23, 2026 14:53

@yhong123 yhong123 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It runs well on my machine.

@yhong123 yhong123 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tim-band , I noticed that running poetry run python -m unittest on this PR on my machine results in 2 failures and 1 error:

  • tests.test_dump.EndToEndParquetTestCase.test_end_to_end_parquet
    • Error: FileNotFoundError: [Errno 2] No such file or directory: 'orm_auto.yaml'
  • tests.test_dump.CurrentDirEndToEndParquetTestCase.test_end_to_end_parquet
    • Failure: AssertionError: 0 != 1
  • tests.test_functional.MsSqlFunctionalTestCase.test_workflow_maximal_args
    • Failure: KeyError: 'empty_vocabulary'

I have checked that these failures do not occur on the main branch.

@tim-band

Copy link
Copy Markdown
Collaborator Author

Hi @tim-band , I noticed that running poetry run python -m unittest on this PR on my machine results in 2 failures and 1 error:

* `tests.test_dump.EndToEndParquetTestCase.test_end_to_end_parquet`
  
  * Error: `FileNotFoundError: [Errno 2] No such file or directory: 'orm_auto.yaml'`

* `tests.test_dump.CurrentDirEndToEndParquetTestCase.test_end_to_end_parquet`
  
  * Failure: `AssertionError: 0 != 1`

* `tests.test_functional.MsSqlFunctionalTestCase.test_workflow_maximal_args`
  
  * Failure: `KeyError: 'empty_vocabulary'`

I have checked that these failures do not occur on the main branch.

Thanks for testing this. I cannot reproduce it; perhaps we can look at these failures on your machine. I have made a small change to help test_end_to_end_parquet fail in a more descriptive manner, but it won't make it pass.

@yhong123

Copy link
Copy Markdown
Collaborator

I pulled the latest changes, and there are three test failures now. I can show you the issue on my machine, just let me know when you're available.

Also, I forgot to mention this in my previous message. When the tests start, I see the following error:

F......(_duckdb.CatalogException) Catalog Error: SET search_path: No catalog + schema named "public" found.
(Background on this error at: https://sqlalche.me/e/20/f405)

I think we've seen a similar error before while working on the mssql branch, and I believe you fixed it there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use colours on interactive configuration commands

2 participants