Skip to content

Update README and correct version number#300

Open
mknaranja wants to merge 2 commits into
mainfrom
mknaranja-patch-1
Open

Update README and correct version number#300
mknaranja wants to merge 2 commits into
mainfrom
mknaranja-patch-1

Conversation

@mknaranja

@mknaranja mknaranja commented Jun 27, 2026

Copy link
Copy Markdown
Member

Merge Request - GuideLine Checklist

Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.

Checks by code author:

Always to be checked:

  • There is at least one issue associated with the pull request.
  • New code adheres with the coding guidelines
  • No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

If functions were changed or functionality was added:

  • Tests for new functionality has been added
  • A local test was succesful

If new functionality was added:

  • There is appropriate documentation of your work. (use doxygen style comments)

If new third party software is used:

  • Did you pay attention to its license? Please remember to add it to the wiki after successful merging.

If new mathematical methods or epidemiological terms are used:

  • Are new methods referenced? Did you provide further documentation?

Checks by code reviewer(s):

  • Is the code clean of development artifacts e.g., unnecessary comments, prints, ...
  • The ticket goals for each associated issue are reached or problems are clearly addressed (i.e., a new issue was introduced).
  • There are appropriate unit tests and they pass.
  • The git history is clean and linearized for the merge request. All reviewers should squash commits and write a simple and meaningful commit message.
  • Coverage report for new code is acceptable.
  • No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

Comment thread README.md Outdated
Comment on lines 220 to 226
6. **Testing**
- Added formatting validation tests and automatic CI testing with MUMPS.

### GMGPolar 2.3.0

GMGPolar v2.3.0 finalizes the integration of Kokkos for GPU acceleration with GMGPolar.
- Added Google Tests for PCG convergence validation.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it expected that this last point has moved from 2.2.0-G to 2.3.0 ?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had actually removed the "-G" from the release (after you had commented on it). So I deleted it above (which was wrong anyway) and now continue as before.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I noticed, but I wasn't sure if the -G was a way of indicating a development version of if it was just a typo. If it was a typo then the line:

  • Added Google Tests for PCG convergence validation.

has changed section

@codecov

codecov Bot commented Jun 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.41%. Comparing base (3191096) to head (a262307).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #300   +/-   ##
=======================================
  Coverage   97.41%   97.41%           
=======================================
  Files          79       79           
  Lines        8653     8653           
=======================================
  Hits         8429     8429           
  Misses        224      224           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mknaranja mknaranja changed the title Update README.md Update README and correct version number Jun 29, 2026
@tpadioleau

Copy link
Copy Markdown
Contributor

Should there be an entry explaining the change in 2.3.1 in the README ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants