Skip to content

fix downloading pre-built binary#43

Open
piotrek-janus wants to merge 2 commits into
masterfrom
feature/fix-pre-built-binary-download
Open

fix downloading pre-built binary#43
piotrek-janus wants to merge 2 commits into
masterfrom
feature/fix-pre-built-binary-download

Conversation

@piotrek-janus

@piotrek-janus piotrek-janus commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Fix downloading pre-built binary.

Before this PR, both REPO and VERSION variables were not properly resolved, which required rebuilding it during action execution

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to fix how the composite GitHub Action determines which pre-built cac binary release to download, so action executions can use cached/downloaded binaries instead of rebuilding from source.

Changes:

  • Adds a step to resolve the action “version” and uses it for the cache key.
  • Updates the download logic to use the resolved version (and hard-codes the repository used for release downloads).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread action.yaml Outdated
github.action_path only ends with the ref for remote usage
(uses: owner/repo@ref). For local usage (uses: ./) it is the
checked-out repo directory, so the previous ${AP##*/} resolved the
version to the repo directory name, breaking the download URL and cache
key and forcing a build from source.

Parse owner/repo/ref from the _actions path for remote usage, and fall
back to the caller repo plus the exact checked-out git tag for local
usage. This also removes the hard-coded repository, making the action
portable to forks and renames.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants