fix(inference): block cross-engine AgentX STP comparisons / 阻止 AgentX STP 跨引擎对比#549
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b27615f. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Medium Risk
Touches core inference comparison UX (legend, overlays, presets, URL restore) and new sequence-scoped rules; mistakes could hide valid configs or allow misleading cross-engine charts, but behavior is heavily tested.
Overview
Agentic Traces now enforces a sequence-scoped STP rule: unsuffixed standard-token configs from different engine families (e.g. SGLang/ATOM vs vLLM) cannot share one comparison view. Fixed-sequence STP is unchanged. The rule merges with existing DeepSeek V4 MTP exclusions; MTP strip prefixes also cover llm-d and Mooncake wrappers.
Inference selection is centralized via
resolveComparisonSelection/toggleComparisonSelection: legend toggles, GPU timeline picks, URL/preset restores, and unofficial overlay keys (overlay:namespace) all go through the same resolver. Agentic views use a keep-sticky policy (one engine family kept on auto-reset); other scenarios keep clear-all. The MTP-specific toast is replaced byEngineComparisonConflictToastwith blocked vs resolved messaging (EN/ZH).Chart surfaces apply the guard in
ScatterGraph(drops conflicting overlay rooflines and syncs overlay state) andChartDisplay(table rows and CSV warning inputs usevisibleComparisonRowswith quick filters). Preset hw matching ignores only non-null exclusion suffixes. Unit and Cypress tests cover STP grouping, overlay/table behavior, and regression cases.Reviewed by Cursor Bugbot for commit 86e0bb7. Bugbot is set up for automated code reviews on this repo. Configure here.