Skip to content

fix(inference): block cross-engine AgentX STP comparisons / 阻止 AgentX STP 跨引擎对比#549

Merged
adibarra merged 4 commits into
masterfrom
fix/agentx-stp-engine-comparisons
Jul 10, 2026
Merged

fix(inference): block cross-engine AgentX STP comparisons / 阻止 AgentX STP 跨引擎对比#549
adibarra merged 4 commits into
masterfrom
fix/agentx-stp-engine-comparisons

Conversation

@adibarra

@adibarra adibarra commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Note

Medium Risk
Touches core inference comparison UX (legend, overlays, presets, URL restore) and new sequence-scoped rules; mistakes could hide valid configs or allow misleading cross-engine charts, but behavior is heavily tested.

Overview
Agentic Traces now enforces a sequence-scoped STP rule: unsuffixed standard-token configs from different engine families (e.g. SGLang/ATOM vs vLLM) cannot share one comparison view. Fixed-sequence STP is unchanged. The rule merges with existing DeepSeek V4 MTP exclusions; MTP strip prefixes also cover llm-d and Mooncake wrappers.

Inference selection is centralized via resolveComparisonSelection / toggleComparisonSelection: legend toggles, GPU timeline picks, URL/preset restores, and unofficial overlay keys (overlay: namespace) all go through the same resolver. Agentic views use a keep-sticky policy (one engine family kept on auto-reset); other scenarios keep clear-all. The MTP-specific toast is replaced by EngineComparisonConflictToast with blocked vs resolved messaging (EN/ZH).

Chart surfaces apply the guard in ScatterGraph (drops conflicting overlay rooflines and syncs overlay state) and ChartDisplay (table rows and CSV warning inputs use visibleComparisonRows with quick filters). Preset hw matching ignores only non-null exclusion suffixes. Unit and Cypress tests cover STP grouping, overlay/table behavior, and regression cases.

Reviewed by Cursor Bugbot for commit 86e0bb7. Bugbot is set up for automated code reviews on this repo. Configure here.

@vercel

vercel Bot commented Jul 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
inferencemax-app Ready Ready Preview, Comment Jul 10, 2026 6:03am

Request Review

Comment thread packages/app/src/components/inference/ui/ChartDisplay.tsx Outdated
Comment thread packages/app/src/components/inference/ui/ChartDisplay.tsx Outdated

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit b27615f. Configure here.

Comment thread packages/app/src/components/inference/InferenceContext.tsx Outdated
@adibarra adibarra merged commit 5402406 into master Jul 10, 2026
23 checks passed
@adibarra adibarra deleted the fix/agentx-stp-engine-comparisons branch July 10, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant