Skip to content

[AMD] KIMI fp4 MI355 update docker#2132

Open
benenzhu wants to merge 23 commits into
mainfrom
amd/zty_test2
Open

[AMD] KIMI fp4 MI355 update docker#2132
benenzhu wants to merge 23 commits into
mainfrom
amd/zty_test2

Conversation

@benenzhu

@benenzhu benenzhu commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator
  1. Update to new ATOM images.
  2. Remove Tp8, cause it consistently slower then TP4

co-author-by: @valarLip, @coderfeli, @Bernard-Liu

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Thanks for the contribution! Please reach out to respective companies' CODEOWNER to fill in the latest PR_REVIEW_CHECKLIST.md before pinging core maintainer on Slack for review. In order for the signoff PR check bot to trigger, you must follow the PR_REVIEW_CHECKLIST.md template correctly, including the phrase As a PR reviewer and CODEOWNER, I have reviewed this and have.

For PR verification, add the full-sweep-fail-fast label (strongly recommended) to this PR — the benchmark sweep only runs on labeled PRs. Use full-sweep-enabled only if you need matrix jobs to keep running past a failure.

PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. See GitHub's docs on re-running failed jobs


感谢你的贡献!请联系相应公司的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md,然后再在 Slack 上联系核心维护者进行审阅。为了触发 signoff PR 检查机器人,你必须正确遵循 PR_REVIEW_CHECKLIST.md 模板,包括保留英文语句 As a PR reviewer and CODEOWNER, I have reviewed this and have

如需进行 PR 验证,请为此 PR 添加 full-sweep-fail-fast 标签(强烈推荐)— 基准测试 sweep 仅在带有标签的 PR 上运行。仅当需要矩阵任务在失败后继续运行时才使用 full-sweep-enabled

PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动(flake),重新运行失败的任务即可解决。参见 GitHub 关于重新运行失败任务的文档

@benenzhu benenzhu changed the title [AMD] [WIP] [DNM] Amd/zty test2 [AMD] [WIP] [DRAFT] KIMI fp4 MI355 Jul 9, 2026
@benenzhu benenzhu marked this pull request as draft July 9, 2026 16:16
Comment thread configs/amd-master.yaml Outdated
@benenzhu benenzhu marked this pull request as ready for review July 9, 2026 16:25
@claude

claude Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Claude finished @benenzhu's task in 3m 35s —— View job


Review: KIMI fp4 MI355 recipe update

  • Gather context and diff against origin/main
  • Review configs/amd-master.yaml changes
  • Review benchmark script changes
  • Validate perf-changelog.yaml entry against the changelog gate
  • Post inline comments

Findings

1 blocking issue (inline comment): the new perf-changelog.yaml entry is indented 2 extra spaces ( - config-keys: instead of - config-keys: at column 0). This is invalid YAML — utils/validate_perf_changelog.py will fail to parse the file (and its append-format check would reject it anyway), so the changelog gate in run-sweep.yml fails and the sweep for kimik2.5-fp4-mi355x-atom never triggers. The suggestion in the inline comment fixes the indentation and also replaces the placeholder "TODO & update image" description with one documenting the actual changes.

1 warning (inline comment): --scheduler-delay-factor 1 was appended onto the -tp $TP line in the benchmark script; repo style requires one server-launch argument per line.

Notes

  • Both issues from the previous review are resolved: the image is now the org-owned rocm/atom-dev:nightly_202607091539 (no longer a personal namespace), and a perf-changelog.yaml entry was added (correctly appended at the end).
  • I could not verify externally that the rocm/atom-dev:nightly_202607091539 tag is actually published on Docker Hub (the timestamp suggests it was pushed today, 2026-07-09 15:39) — please confirm it's public before merging, otherwise the sweep will fail at image pull.
  • The TP8 search-space narrowing to a single concurrency point (conc 4) for both scenarios and the new AITER/ATOM env vars look intentional; the EP flag remains correctly conditional on EP_SIZE.

Fix the changelog entry →

Comment thread perf-changelog.yaml Outdated
Comment thread benchmarks/single_node/fixed_seq_len/kimik2.5_fp4_mi355x_atom.sh Outdated
benenzhu and others added 2 commits July 10, 2026 00:33
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
@SemiAnalysisAI SemiAnalysisAI deleted a comment from github-actions Bot Jul 9, 2026
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@SemiAnalysisAI SemiAnalysisAI deleted a comment from github-actions Bot Jul 10, 2026
@SemiAnalysisAI SemiAnalysisAI deleted a comment from github-actions Bot Jul 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

@benenzhu benenzhu changed the title [AMD] [WIP] [DRAFT] KIMI fp4 MI355 [AMD] [WIP] KIMI fp4 MI355 Jul 10, 2026
@benenzhu benenzhu changed the title [AMD] [WIP] KIMI fp4 MI355 [AMD] [WIP] KIMI fp4 MI355 update docker Jul 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

@benenzhu benenzhu changed the title [AMD] [WIP] KIMI fp4 MI355 update docker [AMD] KIMI fp4 MI355 update docker Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant