Skip to content

[WIP] Comparison branch for #2148: BF16 gate on main#2149

Open
jasonlizhengjian wants to merge 5 commits into
mainfrom
codex/minimaxm3-b300-bf16-gate-test
Open

[WIP] Comparison branch for #2148: BF16 gate on main#2149
jasonlizhengjian wants to merge 5 commits into
mainfrom
codex/minimaxm3-b300-bf16-gate-test

Conversation

@jasonlizhengjian

@jasonlizhengjian jasonlizhengjian commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

This is a comparison branch for #2148 that tests the MiniMax-M3 BF16 routing gate directly against main.

It keeps main's vLLM image, bundled FlashInfer runtime, and serving configuration unchanged. The only runtime difference is a vLLM MiniMax-M3 gate patch that changes the routing gate parameter dtype from FP32 to BF16 while preserving FP32 output. DP-attention rows are omitted from the sweep.

Motivation

PR #2148's latest-nightly TP2 c256 result regressed despite effectively identical available memory and KV-cache capacity. Since main is already faster, this PR measures the BF16 gate change on the main runtime without carrying over #2148's FlashInfer nightly, image, FP8 indexer-KV, or timeout changes.

Validation

  • bash -n benchmarks/single_node/fixed_seq_len/minimaxm3_fp4_b300.sh
  • utils/validate_perf_changelog.py against origin/main
  • Generated matrix: 20 single-node 1k/1k rows, 11 single-node 8k/1k rows, and 2 eval rows
  • Confirmed 8k/1k TP2 includes concurrency 4 through 256 on main's nightly-93d8f834dd8acf33eb0e2a75b2711b628cb6e226 image with DP attention disabled

@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the contribution! Please reach out to respective companies' CODEOWNER to fill in the latest PR_REVIEW_CHECKLIST.md before pinging core maintainer on Slack for review. In order for the signoff PR check bot to trigger, you must follow the PR_REVIEW_CHECKLIST.md template correctly, including the phrase As a PR reviewer and CODEOWNER, I have reviewed this and have.

For PR verification, add the full-sweep-fail-fast label (strongly recommended) to this PR — the benchmark sweep only runs on labeled PRs. Use full-sweep-enabled only if you need matrix jobs to keep running past a failure.

PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. See GitHub's docs on re-running failed jobs


感谢你的贡献!请联系相应公司的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md,然后再在 Slack 上联系核心维护者进行审阅。为了触发 signoff PR 检查机器人,你必须正确遵循 PR_REVIEW_CHECKLIST.md 模板,包括保留英文语句 As a PR reviewer and CODEOWNER, I have reviewed this and have

如需进行 PR 验证,请为此 PR 添加 full-sweep-fail-fast 标签(强烈推荐)— 基准测试 sweep 仅在带有标签的 PR 上运行。仅当需要矩阵任务在失败后继续运行时才使用 full-sweep-enabled

PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动(flake),重新运行失败的任务即可解决。参见 GitHub 关于重新运行失败任务的文档

@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the contribution! Please reach out to respective companies' CODEOWNER to fill in the latest PR_REVIEW_CHECKLIST.md before pinging core maintainer on Slack for review. In order for the signoff PR check bot to trigger, you must follow the PR_REVIEW_CHECKLIST.md template correctly, including the phrase As a PR reviewer and CODEOWNER, I have reviewed this and have.

For PR verification, add the full-sweep-fail-fast label (strongly recommended) to this PR — the benchmark sweep only runs on labeled PRs. Use full-sweep-enabled only if you need matrix jobs to keep running past a failure.

PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. See GitHub's docs on re-running failed jobs


感谢你的贡献!请联系相应公司的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md,然后再在 Slack 上联系核心维护者进行审阅。为了触发 signoff PR 检查机器人,你必须正确遵循 PR_REVIEW_CHECKLIST.md 模板,包括保留英文语句 As a PR reviewer and CODEOWNER, I have reviewed this and have

如需进行 PR 验证,请为此 PR 添加 full-sweep-fail-fast 标签(强烈推荐)— 基准测试 sweep 仅在带有标签的 PR 上运行。仅当需要矩阵任务在失败后继续运行时才使用 full-sweep-enabled

PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动(flake),重新运行失败的任务即可解决。参见 GitHub 关于重新运行失败任务的文档

@jasonlizhengjian jasonlizhengjian changed the title [WIP] Test branch of #2148: MiniMax-M3 BF16 gate [WIP] Comparison branch for #2148: BF16 gate on main Jul 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant