Skip to content

chore: stop stat'ing assets whose sizes nothing reads - #8

Open
anurag6569201 wants to merge 1 commit into
qa/agent-sveltejs-kit/pr-08-16996/basefrom
qa/agent-sveltejs-kit/pr-08-16996/head
Open

anurag6569201 wants to merge 1 commit into
qa/agent-sveltejs-kit/pr-08-16996/basefrom
qa/agent-sveltejs-kit/pr-08-16996/head

Conversation

@anurag6569201

Copy link
Copy Markdown

builder.mimeTypes stats every server asset for a size it never returns, and create_assets stats every file in static/ for a size field nothing reads. Both calls are removed.

Summary by CodeRabbit

  • Performance

    • Reduced unnecessary filesystem checks when processing static and server assets, improving build efficiency.
  • Bug Fixes

    • Simplified asset metadata by removing file-size information that was not needed.
    • Asset records now retain relevant file paths and MIME types without exposing size values.

Source merge-base: 03f1687fe612ce3d2d9131139b5b188d9cf90c64
Source head: 04cc35018b58fa753b9d8a55ed43d1a9c7f3ff83

@shipwright-agent

Copy link
Copy Markdown

✅ Shipwright · Approve

Recommendation: approve PR #8 · Tier T1
Checks: 0 total · 0 needing attention

Next step: ready to merge.

Findings

✅ No actionable findings detected.

Fireworks usage: 6,154 input · 23 output · 6,177 total tokens · $0.0014 · 3s · 0 fix iteration(s)

Open the Shipwright check for full evidence and the audit bundle. Use /shipwright rerun to verify again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant