Skip to content

Improve the Vercel & Slack integration settings pages - #15

Open
anurag6569201 wants to merge 1 commit into
qa/agent-triggerdotdev-trigger-dev/pr-10-4848/basefrom
qa/agent-triggerdotdev-trigger-dev/pr-10-4848/head
Open

Improve the Vercel & Slack integration settings pages#15
anurag6569201 wants to merge 1 commit into
qa/agent-triggerdotdev-trigger-dev/pr-10-4848/basefrom
qa/agent-triggerdotdev-trigger-dev/pr-10-4848/head

Conversation

@anurag6569201

Copy link
Copy Markdown

What

Updated layout for the Vercel and Slack organization integration settings pages to match the rest of the settings UI. Layout & UI only — no loader/action/logic changes.

Blank states (no integration)

  • Added the app title bar (it was missing on the Vercel page)
  • Centered logo + heading + copy, with the two pages mirroring each other
  • A project picker CTA that deep-links to where each integration is configured for the chosen project — Vercel → the project's integrations page; Slack → the Errors page alerts sheet (?alerts=true) — styled like the side-menu project switcher

Connected states

  • Rebuilt on SettingsContainer / SettingsSection / SettingsHeader / SettingsRow
  • An Overview section with detail rows + a Remove integration row (confirmation dialog kept)
  • A connected projects / alert channels table that fits the settings column
  • Vercel: copyable Team/Installation IDs (CopyableText), a sticky Configure cog action per row
  • Slack: mirrors the same layout (Workspace / Installed / Remove + alert channels table)
CleanShot 2026-08-31 at 10 47 37 CleanShot 2026-09-01 at 19 40 18@2x CleanShot 2026-09-01 at 19 40 28@2x

🤖 Generated with Claude Code


Open workspace in Conductor

Source merge-base: 97e3f0aa26e080be171fd85ed5eb3cf525e53891
Source head: 97cebf51132c1cdf17e1041367759a951a9e632f

@shipwright-agent

Copy link
Copy Markdown

⛔ Shipwright · Blocked

Recommendation: do not merge PR #15 · Tier T2
Checks: 0 total · 0 needing attention

Next step: resolve the blocking findings before merge.

Findings (2)

  • CRITICAL In the Vercel no-integration branch, 'organization' is referenced in 'configurePathFor' but only 'projects' is destructured from 'useOrganization()'. · organizationSlug.settings.integrations.vercel.tsx:263
    • Fix: Review the cited evidence, fix the risk if confirmed, and rerun Shipwright.
  • HIGH In the Vercel no-integration branch, 'organization' is referenced in 'configurePathFor' but only 'projects' is destructured from 'useOrganization()'. · apps/webapp/app/routes/_app.orgs.$organizationSlug.settings.integrations.vercel.tsx:263
    • Fix: Fix the review finding before release.

Fireworks usage: 19,510 input · 233 output · 19,743 total tokens · $0.0044 · 7s · 0 fix iteration(s)

Open the Shipwright check for full evidence and the audit bundle. Use /shipwright rerun to verify again.

const isUninstalling =
navigation.state === "submitting" && navigation.formData?.get("intent") === "uninstall";

const { projects } = useOrganization();

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shipwright · HIGH

In the Vercel no-integration branch, 'organization' is referenced in 'configurePathFor' but only 'projects' is destructured from 'useOrganization()'.

Impact: In the Vercel no-integration branch, 'organization' is referenced in 'configurePathFor' but only 'projects' is destructured from 'useOrganization()'. This causes a ReferenceError when a Vercel integration is not configured and the organization has projects.

Suggested fix: Fix the review finding before release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant