Skip to content

chore(webapp): integration settings copy update - #16

Open
anurag6569201 wants to merge 1 commit into
qa/agent-triggerdotdev-trigger-dev/pr-12-4850/basefrom
qa/agent-triggerdotdev-trigger-dev/pr-12-4850/head
Open

chore(webapp): integration settings copy update#16
anurag6569201 wants to merge 1 commit into
qa/agent-triggerdotdev-trigger-dev/pr-12-4850/basefrom
qa/agent-triggerdotdev-trigger-dev/pr-12-4850/head

Conversation

@anurag6569201

Copy link
Copy Markdown

Project → Settings → Integrations, build settings for GitHub deploys:

  • Trigger config file: description now says it is auto-detected by default and a path only overrides that.
  • Use native build server: rendered only for admins — GitHub deployments always use the native build server unless an admin opts a project out. The option to disable native builds in GitHub deployments will be removed entirely.

Source merge-base: 1d55693c0fc76279e7e8275fe41f959b65d5ea99
Source head: 5fd54fb704a2dec020097ed9df239bc6134ff115

@shipwright-agent

Copy link
Copy Markdown

⛔ Shipwright · Blocked

Recommendation: do not merge PR #16 · Tier T1
Checks: 0 total · 0 needing attention

Next step: resolve the blocking findings before merge.

Findings (5)

  • CRITICAL The action reads the stored build settings with 'prisma.project.findFirst' and parses them with 'BuildSettingsSchema.safeParse', but if the project is not found or the stored setti · envParam.settings.integrations/route.tsx:190
    • Fix: Review the cited evidence, fix the risk if confirmed, and rerun Shipwright.
  • CRITICAL Authorization is enforced only in the UI and action handler, but the action handler's admin check is bypassable via impersonation. · envParam.settings.integrations/route.tsx:188
    • Fix: Review the cited evidence, fix the risk if confirmed, and rerun Shipwright.
  • CRITICAL The admin-only UI gate uses 'useHasAdminAccess()' to hide the switch, but the server action does not enforce the same authorization boundary. · envParam.settings.integrations/route.tsx:188
    • Fix: Review the cited evidence, fix the risk if confirmed, and rerun Shipwright.
  • HIGH The authorization logic is split between 'useHasAdminAccess()' in the component and 'user.admin && user.isImpersonating' in the action, with different semantics. · envParam.settings.integrations/route.tsx:188
    • Fix: Review the cited evidence, fix the risk if confirmed, and rerun Shipwright.
  • HIGH The new 'prisma.project.findFirst' query is executed on every non-admin save, adding a database round-trip inside the action. · envParam.settings.integrations/route.tsx:190
    • Fix: Review the cited evidence, fix the risk if confirmed, and rerun Shipwright.

Fireworks usage: 8,653 input · 744 output · 9,397 total tokens · $0.0024 · 13s · 0 fix iteration(s)

Open the Shipwright check for full evidence and the audit bundle. Use /shipwright rerun to verify again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant