Skip to content

fix(clickhouse): drop obsolete task event index variants - #9

Open
anurag6569201 wants to merge 1 commit into
qa/agent-triggerdotdev-trigger-dev/pr-16-4880/basefrom
qa/agent-triggerdotdev-trigger-dev/pr-16-4880/head
Open

fix(clickhouse): drop obsolete task event index variants#9
anurag6569201 wants to merge 1 commit into
qa/agent-triggerdotdev-trigger-dev/pr-16-4880/basefrom
qa/agent-triggerdotdev-trigger-dev/pr-16-4880/head

Conversation

@anurag6569201

Copy link
Copy Markdown

Summary

Removes the obsolete task event full-text indexes in one ALTER TABLE, accounting for both known index naming variants.

Fix

The original migration issued back-to-back alters while ClickHouse could still be processing the preceding index mutation. Combining the index removals avoids scheduling a subsequent alter against an unfinished mutation.

The native JSON storage change is deferred until it can be performed without rewriting populated parts.

Source merge-base: 8d78ec5144dbdac9fc76ea89c2cef4a1b04efe57
Source head: 8d31ef4dfd27885a4b89c37a6c104b035ef9f5b8

@shipwright-agent

Copy link
Copy Markdown

⛔ Shipwright · Blocked

Recommendation: do not merge PR #9 · Tier T3
Checks: 0 total · 0 needing attention

Next step: resolve the blocking findings before merge.

Findings (4)

  • CRITICAL The migration drops index 'message_text_search' but the pre-existing index name was 'idx_message_text_search'. · internal-packages/clickhouse/schema/042_reduce_task_events_v2_storage_overhead.sql:8
    • Fix: Review the cited evidence, fix the risk if confirmed, and rerun Shipwright.
  • HIGH The migration drops index 'message_text_search' but the test query checks for 'message_text_search' while the original index name in the previous migration was 'idx_message_text_se · internal-packages/clickhouse/schema/042_reduce_task_events_v2_storage_overhead.sql:8
    • Fix: Fix the review finding before release.
  • HIGH The test now asserts that 'attributes' has empty default_kind and default_expression, but the migration no longer modifies the attributes column. · internal-packages/clickhouse/src/taskEvents.test.ts:85
    • Fix: Review the cited evidence, fix the risk if confirmed, and rerun Shipwright.
  • HIGH The migration removes the explicit EPHEMERAL column change and the rollback guard. · internal-packages/clickhouse/schema/042_reduce_task_events_v2_storage_overhead.sql:12
    • Fix: Review the cited evidence, fix the risk if confirmed, and rerun Shipwright.

Fireworks usage: 6,771 input · 480 output · 7,251 total tokens · $0.0018 · 9s · 0 fix iteration(s)

Open the Shipwright check for full evidence and the audit bundle. Use /shipwright rerun to verify again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant