Skip middleware actions for zero-sample profiles#217
Open
oiahoon wants to merge 1 commit into
Open
Conversation
Author
|
I have signed the CLA! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unusable empty profiles no longer trigger middleware actions. The middleware now returns the original response when StackProf reports zero samples instead of uploading, enqueueing, or viewing a profile that Speedscope cannot consume.
Behavior
The zero-sample guard runs after
after_profile, preserving the existing hook behavior and direct backend/profile APIs. Profiles with positive samples and backends without the StackProfsamplesfield are unchanged.Verification
UploadAction.callgit diff --checkCloses #2