Skip to content

Omit undefined optional props on AcceleratedCheckoutButtons #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JoaoPauloCMarra wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Omit undefined optional props on AcceleratedCheckoutButtons #521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a811f6
Omit undefined optional props on AcceleratedCheckoutButtons
JoaoPauloCMarra Sep 1, 2026
6663e8b
test: cover accelerated checkout apple pay label
JoaoPauloCMarra Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions modules/@shopify/checkout-sheet-kit/src/components/AcceleratedCheckoutButtons.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,12 +304,16 @@ export const AcceleratedCheckoutButtons: React.FC<
return (
<RCTAcceleratedCheckoutButtons
testID="accelerated-checkout-buttons"
applePayLabel={applePayLabel}
applePayStyle={applePayStyle}
style={{...defaultStyles, height: dynamicHeight}}
{...(applePayLabel === undefined ? {} : {applePayLabel})}
{...(applePayStyle === undefined ? {} : {applePayStyle})}
style={
dynamicHeight === undefined
? defaultStyles
: {...defaultStyles, height: dynamicHeight}
}
checkoutIdentifier={checkoutIdentifier}
cornerRadius={cornerRadius}
wallets={wallets}
{...(cornerRadius === undefined ? {} : {cornerRadius})}
{...(wallets === undefined ? {} : {wallets})}
onFail={handleFail}
onComplete={handleComplete}
onCancel={handleCancel}
Expand Down
25 changes: 25 additions & 0 deletions modules/@shopify/checkout-sheet-kit/tests/AcceleratedCheckoutButtons.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import {Platform} from 'react-native';
import {
AcceleratedCheckoutButtons,
AcceleratedCheckoutWallet,
ApplePayLabel,
ApplePayStyle,
RenderState,
} from '../src';
Expand Down Expand Up @@ -98,6 +99,7 @@ describe('AcceleratedCheckoutButtons', () => {
cartId={'gid://shopify/Cart/123'}
cornerRadius={12}
wallets={[AcceleratedCheckoutWallet.shopPay]}
applePayLabel={ApplePayLabel.buy}
applePayStyle={ApplePayStyle.black}
/>,
);
Expand All @@ -111,6 +113,7 @@ describe('AcceleratedCheckoutButtons', () => {
expect(nativeComponent.props.wallets).toEqual([
AcceleratedCheckoutWallet.shopPay,
]);
expect(nativeComponent.props.applePayLabel).toBe(ApplePayLabel.buy);
expect(nativeComponent.props.applePayStyle).toBe(ApplePayStyle.black);
});

Expand Down Expand Up @@ -143,6 +146,28 @@ describe('AcceleratedCheckoutButtons', () => {
expect(nativeComponent.props.cornerRadius).toBeUndefined();
});

it('omits optional props when they are not provided', () => {
const {getByTestId} = render(
<AcceleratedCheckoutButtons cartId="gid://shopify/Cart/123" />,
);

const nativeComponent = getByTestId('accelerated-checkout-buttons');
expect(nativeComponent).toBeTruthy();
expect(nativeComponent.props).not.toHaveProperty('applePayLabel');
expect(nativeComponent.props).not.toHaveProperty('applePayStyle');
expect(nativeComponent.props).not.toHaveProperty('cornerRadius');
expect(nativeComponent.props).not.toHaveProperty('wallets');
});

it('omits height from style until a size is reported', () => {
const {getByTestId} = render(
<AcceleratedCheckoutButtons cartId="gid://shopify/Cart/123" />,
);

const nativeComponent = getByTestId('accelerated-checkout-buttons');
expect(nativeComponent.props.style).toEqual({flex: 1});
});

it('passes through custom quantity and cornerRadius', () => {
const {getByTestId} = render(
<AcceleratedCheckoutButtons
Expand Down
Loading