Skip to content

[Tests] Add unit tests for isValidMetricName validator - #8384

Draft
gonzaloriestra wants to merge 1 commit into
mainfrom
tests-cover-otel-validators-15547795319124221370
Draft

[Tests] Add unit tests for isValidMetricName validator#8384
gonzaloriestra wants to merge 1 commit into
mainfrom
tests-cover-otel-validators-15547795319124221370

Conversation

@gonzaloriestra

Copy link
Copy Markdown
Contributor

What page / article is this about?

This PR adds unit tests for isValidMetricName in @shopify/cli-kit.

What changed?

  • Added unit test file packages/cli-kit/src/public/node/vendor/otel-js/utils/validators.test.ts.
  • Tested isValidMetricName with valid metric names (valid_metric_name, metric, _metric, METRIC_NAME) returning true.
  • Tested isValidMetricName with invalid metric names (invalid-metric, 123metric, metric.name, metric@name, metric name) returning false and triggering a diagnostic warning via diag.warn.

How to test your changes?

CI

Checklist


PR created automatically by Jules for task 15547795319124221370 started by @gonzaloriestra

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant