[Tests] Add unit tests for isValidMetricName validator - #8384
[Tests] Add unit tests for isValidMetricName validator#8384gonzaloriestra wants to merge 1 commit into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
What page / article is this about?
This PR adds unit tests for
isValidMetricNamein@shopify/cli-kit.What changed?
packages/cli-kit/src/public/node/vendor/otel-js/utils/validators.test.ts.isValidMetricNamewith valid metric names (valid_metric_name,metric,_metric,METRIC_NAME) returningtrue.isValidMetricNamewith invalid metric names (invalid-metric,123metric,metric.name,metric@name,metric name) returningfalseand triggering a diagnostic warning viadiag.warn.How to test your changes?
CI
Checklist
PR created automatically by Jules for task 15547795319124221370 started by @gonzaloriestra