Skip to content

Report store lifecycle command telemetry - #8389

Draft
dmerand wants to merge 1 commit into
mainfrom
donald/store-lifecycle-telemetry
Draft

Report store lifecycle command telemetry#8389
dmerand wants to merge 1 commit into
mainfrom
donald/store-lifecycle-telemetry

Conversation

@dmerand

@dmerand dmerand commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

Context: https://github.com/shop/issues-develop/issues/22725

store create dev and store delete print exact JSON for expected errors and exit directly. This path skipped the async command analytics report, so JSON expected failures were invisible in app_cli3_command. Command analytics also had no store attribution for these lifecycle commands.

WHAT is this pull request doing?

Existing command analytics now covers JSON expected failures and gains known store attribution. No new events, no schema changes, and no telemetry-only network requests.

  • Both commands set requiresSyncAnalytics and await expected-error reporting for their JSON AbortError paths before the exact JSON output and direct exit.
  • store delete records the parsed store FQDN as unvalidated; the existing accessible-shop lookup upgrades it to validated with the shop ID when available.
  • store create dev records the returned domain as validated before polling, and its try boundary now covers organization selection and prompts so those expected failures use the same JSON error path.
  • Interactive delete decline stays unreported.

How to test your changes?

No behavior or output change is intended. Run store create dev --json or store delete --json with an expected failure (for example, an inaccessible store) and confirm the JSON error output and exit code are unchanged.

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

No changeset: internal telemetry only, no user-visible behavior or output change.

Assisted-By: devx/9c08eef3-3e18-4b5f-8ed8-bef380040c5d
@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant