Migrate all T::Struct usages to bare Ruby classes - #841
Merged
Conversation
Morriar
force-pushed
the
at-remove-t-struct
branch
2 times, most recently
from
January 8, 2026 16:30
90bd8f6 to
80a1d36
Compare
amomchilov
approved these changes
Jan 8, 2026
amomchilov
left a comment
amomchilov
left a comment
Contributor
There was a problem hiding this comment.
I guess if you migrated to Data.define instead, you'd need a whole bunch of RBI files just to specify the sigs, right?
amomchilov
changed the title
T::Struct usages to bare Ruby classes
Contributor
Author
Indeed, Sorbet doesn't have a way to associate types to data fields yet. |
paracycle
approved these changes
Jan 8, 2026
paracycle
left a comment
paracycle
left a comment
Member
There was a problem hiding this comment.
I have a few minor comments, but looks good to me
Morriar
force-pushed
the
at-remove-t-struct
branch
from
July 31, 2026 15:16
f53e5d5 to
dee12a8
Compare
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Morriar
force-pushed
the
at-remove-t-struct
branch
from
August 4, 2026 18:25
500c9de to
8e59d6f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also enable
Sorbet/ForbidTStructcop after that.