e2e: expand collapsed params panel before asserting param rows#12
Merged
Conversation
ac5a607 made the params panel start collapsed by default; the param rows only render while expanded, so params.spec.ts must click params-panel-toggle before asserting param-width/depth/height.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
params.spec.ts has been failing on main since ac5a607, which made the params panel start collapsed by default. The param rows only render while the panel is expanded, so the spec timed out waiting for param-width.
The collapse is intentional (unit tests were updated with a renderExpanded helper in the same commit), so this is a spec fix, not a product regression: click params-panel-toggle before asserting the rows.
Verified locally:
CHAMFER_FAKE_LLM=1 CHAMFER_DATA_DIR=$(mktemp -d) npx playwright test paramspasses (26s). CI doesn't run e2e, so that local run is the gate.