Add the five remaining build123d modeling skills#19
Merged
Conversation
Pure content on the #18 mechanism: placement-and-frames, booleans-and-features, selectors-and-patterns, holes-and-threads, and surgical-edits, each with the fixed template and executable snippets. All snippets run against real build123d in py-tests, asserting volume deltas, solid counts, and topology, including a measurable demo of the Hole-drills-both-directions gotcha and a surgical edit whose collateral alarms are the assertions. The verify-gate nudge table gains four conservative mappings (first match wins); surgical-edits stays unmapped because a regression is not recognizable from a single failure text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Second half of the skill-layer plan (#18 shipped the mechanism +
sweep-and-loft): the five remaining build123d modeling skills, pure content on the existing machinery.placement-and-framesbooleans-and-featuresselectors-and-patternsholes-and-threadssurgical-editsEvery skill follows the fixed template (when / invariants / recipes / failure signatures / go deeper), stays inside the 350-600 prose-word target (vitest caps at 800), and points down the disclosure chain at
lookup_docstopics andsearch_docsqueries instead of duplicating them.SKILL_NUDGE_RULESgains four mappings (holes, selectors, booleans, placement; first match wins, sweep stays first).surgical-editsis deliberately unmapped - a regression is not detectable from one failure text. Every rule is vitest-checked against the registry.All 15 snippets (10 new) execute against real build123d 0.11.1 in
py-tests/test_skill_snippets.py, with volume/solid-count/topology assertions - including the hole-directions snippet that measurably demonstrates the both-directions gotcha, and the add-slot edit whose first draft accidentally proved the collateral-cut failure mode it warns about (the wall sat mid-plate; caught by its own assertion).Validation
npm run typecheck,npm test(399),npm run buildgreen.py-tests/162 passed, all 21 snippet executions included.Human validation
The 4-condition ablation matrix (
packages/client/eval/run-build123d-ablation.mjs) is now fully unblocked and remains the follow-up measurement.🤖 Generated with Claude Code