Switch sub-driver and main-driver to support SLGA migration by HunsupJung · Pull Request #2842 · SmartThingsCommunity/SmartThingsEdgeDrivers

HunsupJung · 2026-03-18T10:53:30Z

Type of Change

WWST Certification Request
- If this is your first time contributing code:
  - I have reviewed the README.md file
  - I have reviewed the CODE_OF_CONDUCT.md file
  - I have signed the CLA
- I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
Bug fix
New feature
Refactor

Checklist

I have performed a self-review of my code
I have commented my code in hard-to-understand areas
I have verified my changes by testing with a device or have communicated a plan for testing
I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

https://smartthings.atlassian.net/wiki/spaces/STHK/pages/5328012565/SLGA+migration+-+Test+Result

github-actions · 2026-03-18T10:54:00Z

Duplicate profile check: Passed - no duplicate profiles detected.

github-actions · 2026-03-18T10:54:45Z

Invitation URL:
https://bestow-regional.api.smartthings.com/invite/akMXD55p7BMb

github-actions · 2026-03-18T10:55:50Z

Test Results

73 files 515 suites 0s ⏱️
2 908 tests 2 908 ✅ 0 💤 0 ❌
4 804 runs 4 804 ✅ 0 💤 0 ❌

Results for commit 4435fa3.

♻️ This comment has been updated with latest results.

github-actions · 2026-03-18T10:55:52Z

File	Coverage
All files	`80%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/lock_utils.lua	`69%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/lazy_load_subdriver.lua	`57%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/init.lua	`79%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/unmigrated-matter-lock/init.lua	`89%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/unmigrated-matter-lock/can_handle.lua	`81%`	❌

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 4435fa3

tpmanley · 2026-05-27T18:50:29Z

+
+local function lock_op_event_handler(driver, device, ib, response)
+  local tamper_detected = device:get_latest_state(
+                            device:endpoint_to_component(ib.endopint_id),


Suggested change

device:endpoint_to_component(ib.endopint_id),

device:endpoint_to_component(ib.endpoint_id),

tpmanley · 2026-05-27T18:52:39Z

+      command_result_info, {state_change = true, visibility = {displayed = false}}
+    ))
+    device:set_field(lock_utils.BUSY_STATE, false, {persist = true})
+  end


Missing return here?

Yes, I will fix it.

tpmanley · 2026-05-27T19:00:08Z

  MODULAR_PROFILE_UPDATED = "__MODULAR_PROFILE_UPDATED",
  ALIRO_READER_CONFIG_UPDATED = "aliroReaderConfigUpdated",
  LATEST_DOOR_LOCK_FEATURE_MAP = "latestDoorLockFeatureMap",
+  LOCK_CODES_COPY_REQUIRED = "lockCodesCopyRequried",


Suggested change

LOCK_CODES_COPY_REQUIRED = "lockCodesCopyRequried",

LOCK_CODES_COPY_REQUIRED = "lockCodesCopyRequired",

tpmanley · 2026-05-27T19:01:29Z

@@ -0,0 +1,758 @@
+-- Copyright 2025 SmartThings, Inc.


The unit test coverage of this file is currently only 24% so can you add more tests to get more coverage?

okay, I will improve the coverage.

tpmanley · 2026-05-27T19:02:16Z

+  end
+end
+
+-------------------------------------------------------------


The headers of these two functions are swapped

tpmanley · 2026-05-27T19:03:45Z

+  end
+  local protocol_versions = {}
+  for i, element in ipairs(ib.data.elements) do
+    local version = string.format("%s.%s", element.value:byte(1), element.value:byte(2))


To avoid shadowing the module-level version:

Suggested change

local version = string.format("%s.%s", element.value:byte(1), element.value:byte(2))

local ver = string.format("%s.%s", element.value:byte(1), element.value:byte(2))

tpmanley · 2026-05-27T19:04:06Z

+    local version = string.format("%s.%s", element.value:byte(1), element.value:byte(2))
+    table.insert(protocol_versions, version);


To avoid shadowing the module-level version:

Suggested change

local version = string.format("%s.%s", element.value:byte(1), element.value:byte(2))

table.insert(protocol_versions, version);

local ver = string.format("%s.%s", element.value:byte(1), element.value:byte(2))

table.insert(protocol_versions, ver);

Signed-off-by: Hunsup Jung <hunsup.jung@samsung.com>

HunsupJung force-pushed the feature/slga-migration branch 3 times, most recently from eb1ad32 to 9bff284 Compare May 6, 2026 08:38

HunsupJung requested review from ctowns, hcarter-775, nickolas-deboom and tpmanley and removed request for ctowns, hcarter-775, nickolas-deboom and tpmanley May 6, 2026 08:46

HunsupJung force-pushed the feature/slga-migration branch 2 times, most recently from d6d06b2 to d0d0d76 Compare May 26, 2026 11:57

tpmanley reviewed May 27, 2026

View reviewed changes

HunsupJung force-pushed the feature/slga-migration branch from 068d7f9 to 7201bbd Compare June 19, 2026 06:30

HunsupJung added 3 commits June 19, 2026 15:36

Switch sub-driver and main-driver to support SLGA migration

7f32156

Signed-off-by: Hunsup Jung <hunsup.jung@samsung.com>

Update test units

4d09880

Signed-off-by: Hunsup Jung <hunsup.jung@samsung.com>

Modify typo and variable name

810016a

Signed-off-by: Hunsup Jung <hunsup.jung@samsung.com>

HunsupJung force-pushed the feature/slga-migration branch 3 times, most recently from 0bc16a6 to f3f97e2 Compare June 19, 2026 07:31

Change to reassign profile instead of updating existing one

4435fa3

Signed-off-by: Hunsup Jung <hunsup.jung@samsung.com>

HunsupJung force-pushed the feature/slga-migration branch from f3f97e2 to 4435fa3 Compare June 19, 2026 07:34

	device:endpoint_to_component(ib.endopint_id),
	device:endpoint_to_component(ib.endpoint_id),

	LOCK_CODES_COPY_REQUIRED = "lockCodesCopyRequried",
	LOCK_CODES_COPY_REQUIRED = "lockCodesCopyRequired",

	local version = string.format("%s.%s", element.value:byte(1), element.value:byte(2))
	local ver = string.format("%s.%s", element.value:byte(1), element.value:byte(2))

		local version = string.format("%s.%s", element.value:byte(1), element.value:byte(2))
		table.insert(protocol_versions, version);

Conversation

HunsupJung commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of Change

Checklist

Description of Change

Summary of Completed Tests

Uh oh!

github-actions Bot commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Mar 18, 2026

Uh oh!

github-actions Bot commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

github-actions Bot commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

HunsupJung commented Mar 18, 2026 •

edited

Loading

github-actions Bot commented Mar 18, 2026 •

edited

Loading

github-actions Bot commented Mar 18, 2026 •

edited

Loading

github-actions Bot commented Mar 18, 2026 •

edited

Loading