EBP-3100: Remove PubSub+ branding from distributed tracing samples - #99
Merged
Merged
Conversation
Uses the official names from the Solace renamed-products page. Also points the connection-timeout comment at the current docs URL; the old PubSub-branded path redirects to the guide home.
Scope stays on product names. The URL path change belongs with the nine other files that use the same comment.
… the publisher Javadoc
shaanchander-solace
marked this pull request as ready for review
September 21, 2026 19:03
…ependency comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes customer-visible "PubSub+" text from the distributed tracing samples, the ones that exercise
solace-opentelemetry-jcsmp-integration, and uses the official product names throughout the same comment blocks. Part of the JCSMP OTel integration rebrand (EBP-1132).Comments and one printed string, no identifiers or copyable code:
GuaranteedPublisherWithManualInstrumentation.java:51,GuaranteedPublisherWithCustomPropagation.java:54: "Solace PubSub+ Broker" to "Solace Event Broker"GuaranteedPublisherWithManualInstrumentation.java:48,GuaranteedPublisherWithCustomPropagation.java:51: "Solace OpenTelemetry Integration for JCSMP" to the official library name "OpenTelemetry for Solace JCSMP API", so the whole Javadoc block uses current namesQueueSubscriberWithManualInstrumentation.java:114: "PubSub+ Manager WebGUI" to "Broker Manager WebGUI"build.gradle:90, the comment above the tracing dependencies: "Solace OpenTelemetry JCSMP Integration" to "OpenTelemetry for Solace JCSMP API", same reasonNames follow https://docs.solace.com/Release-Notes/renamed-products.htm.
Scope is product names in the tracing samples only. Left as-is on purpose: the docs URL comment at
QueueSubscriberWithManualInstrumentation.java:77still uses the oldSolace-PubSub-Messaging-APIspath. It resolves (it redirects to the developer guide home rather than the timeouts page) and the same comment appears in nine other files, so it belongs with the URL cleanup. Elsewhere, the same "PubSub+ Manager WebGUI" string remains inpatterns/GuaranteedProcessor.java:128andpatterns/GuaranteedSubscriber.java:107, andsemp-rest-api/curl-create-queue-with-subscription.txt:3, which the changed error message points readers to, still says "PubSub+ Manager GUI". In total 17 lines in 13 files, all general JCSMP content or URL paths, left for a separate change so this PR stays tied to the OTel integration work. Happy to widen it here if you would rather take it all at once.Test plan: comment and string edits only. A case-insensitive grep for
pubsuboverfeatures/distributedtracing/now matches only the docs URL path on line 77.