Conversation
…@3.1.3-7 pane-registry@3.1.2-1 solid-panes@4.4.2-2) (latest: rdflib@2.4.0)
NoelDeMartin
approved these changes
Jul 3, 2026
NoelDeMartin
left a comment
NoelDeMartin
left a comment
Member
There was a problem hiding this comment.
I'm always up for deleting code, but this only removes some CSS variables, it doesn't remove any actual CSS... so I assume we'll have to remove the CSS using the variables as well?
I'm not sure what happens with the styles using this variables now that they won't exist. I guess they just resolve to invalid CSS and they fall back to the global styles or something. But we should make sure that those uses didn't have a default value either.
…@3.1.3-9 pane-registry@3.1.2-1 solid-panes@4.4.2-4) (latest: rdflib@2.4.0)
Member
Author
|
right, I should have added the exact same variables in solid-ui. in worst case it won't work... |
…@3.1.3-9 pane-registry@3.1.2-1 solid-panes@4.4.2-4) (latest: rdflib@2.4.0)
…@3.1.3-9 pane-registry@3.1.2-1 solid-panes@4.4.2-4) (latest: rdflib@2.4.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.