Skip to content

fix: Move URL from secrets.toml to config.toml for asset upload feature - BED-9063 #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
StranDutton wants to merge 2 commits into from
Closed

fix: Move URL from secrets.toml to config.toml for asset upload feature - BED-9063 #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9d8534
fix: move url to config.toml for asset upload feature, misc cleanup
StranDutton Jul 27, 2026
445f257
fix typo from last commit
StranDutton Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions src/openhound/core/convert.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
from dlt.pipeline.pipeline import Pipeline

from openhound.core.asset import BaseAsset
from openhound.core.clients.bloodhound import BloodHound
from openhound.core.logging import logger_override
from openhound.core.lookup import LookupManager
from openhound.core.pipeline import BasePipeline
Expand All @@ -22,13 +21,6 @@
logger = logging.getLogger(__name__)


@dataclass
class Credentials:
url: str
token_key: str
token_id: str


class Method(str, Enum):
write = "write"
ingest = "ingest"
Expand All @@ -52,16 +44,6 @@ def __init__(
self.lookup = lookup
self.progress = progress
self.method = method
self.client: BloodHound | None = None
self.upload_id: int | None = None

@property
def _credentials(self) -> Credentials:
return Credentials(
url=dlt.secrets["destination.bloodhound.url"],
token_id=dlt.secrets["destination.bloodhound.token_id"],
token_key=dlt.secrets["destination.bloodhound.token_key"],
)

@property
def pipeline(self) -> Pipeline:
Expand Down
4 changes: 2 additions & 2 deletions src/openhound/destinations/bloodhound/destination.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class Permissions(str, Enum):
def saved_searches(
items: TDataItems,
table: TTableSchema,
url: str = dlt.secrets.value,
url: str = dlt.config.value,
token: str = dlt.secrets.value,
strategy: Strategy = Strategy.skip,
permissions: Permissions = Permissions.public,
Expand Down Expand Up @@ -68,7 +68,7 @@ def saved_searches(
def privilege_zones(
items: TDataItems,
table: TTableSchema,
url: str = dlt.secrets.value,
url: str = dlt.config.value,
token: str = dlt.secrets.value,
strategy: Strategy = Strategy.skip,
):
Expand Down
Loading