fix: removed workflows andset build-and-sign-container.yml to run after build-and-publish.yml completes - #65
Conversation
…and-sign-container.yml to run after build-and-publish.yml completes
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/build-and-publish.yml:
- Around line 39-41: Replace direct GitHub expression expansion inside run
scripts with step-level environment variables at all affected sites: in
.github/workflows/build-and-publish.yml lines 39-41 and 54, pass
github.event.release.tag_name through env and assign REF from RELEASE_TAG; in
.github/workflows/build-and-sign-container.yml line 50, pass inputs.tag through
env and assign CLEAN_VERSION from RELEASE_TAG.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 99cb6e45-1c0f-43ec-bbb0-866f823046ef
📒 Files selected for processing (4)
.github/workflows/build-and-publish.yml.github/workflows/build-and-sign-container.yml.github/workflows/release-on-merge.yml.github/workflows/validate-branch.yml
💤 Files with no reviewable changes (2)
- .github/workflows/release-on-merge.yml
- .github/workflows/validate-branch.yml
Summary
Restructures the release pipeline so that publishing is driven by GitHub (pre-)release events, chains the container build/sign step off the successful PyPI publish, and removes obsolete branch/merge automation.
Changes
Release pipeline (.github/workflows)
build-and-publish.ymlbuild-and-sign-container.ymlSummary by CodeRabbit