Skip to content

Try to improve slide setting accessibility more - #3227

Draft
Crabcyborg wants to merge 5 commits into
improve-slider-setting-accessibilityfrom
try_to_improve_slider_setting_accessibility_more
Draft

Try to improve slide setting accessibility more#3227
Crabcyborg wants to merge 5 commits into
improve-slider-setting-accessibilityfrom
try_to_improve_slider_setting_accessibility_more

Conversation

@Crabcyborg

@Crabcyborg Crabcyborg commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@coderabbitai

coderabbitai Bot commented Aug 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 79f1cdfa-9383-4acc-b8f1-5ed8adaef361

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@deepsource-io

deepsource-io Bot commented Aug 7, 2026

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in 3e9d3f1...e127940 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
PHP Aug 7, 2026 4:27p.m. Review ↗
JavaScript Aug 7, 2026 4:27p.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

deepsource-io[bot]
deepsource-io Bot reviewed Aug 7, 2026
View reviewed changes
Comment thread js/src/settings-components/components/slider-component.js
* @param {number|string} value - The value the slider now represents.
* @return {void}
*/
refreshRange( rangeInput, element, value ) {

@deepsource-io deepsource-io Bot Aug 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected 'this' to be used by class method 'refreshRange'


If a class method does not use this, it can sometimes be made into a static function. If you do convert the method into a static function, instances of the class that call that particular method have to be converted to a static call as well (MyClass.callStaticMethod())

Comment thread js/src/settings-components/components/slider-component.js
@@ -371,6 +542,6 @@ export default class frmSliderComponent {
* @return {string} The unit of measurement ('%', 'px', 'em') found in the value, or an empty string if none is found.
*/
getUnitMeasureFromValue( value ) {

@deepsource-io deepsource-io Bot Aug 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected 'this' to be used by class method 'getUnitMeasureFromValue'


If a class method does not use this, it can sometimes be made into a static function. If you do convert the method into a static function, instances of the class that call that particular method have to be converted to a static call as well (MyClass.callStaticMethod())

deepsource-io[bot]
deepsource-io Bot reviewed Aug 7, 2026
View reviewed changes
Comment thread classes/views/styles/components/templates/slider.php
<div class="frm-slider-container">
<?php FrmAppHelper::icon_by_class( 'frmfont frm-margin-top-bottom' ); ?>
<input type="range" class="frm-slider" min="0" max="<?php echo (int) $component['max_value']; ?>" value="<?php echo esc_attr( $component['vertical']['value'] ); ?>" />
<?php $this->print_range_input( __( 'Vertical value', 'formidable' ), $component['vertical']['value'], $component['vertical']['unit'] ); ?>

@deepsource-io deepsource-io Bot Aug 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $this might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

Comment thread classes/views/styles/components/templates/slider.php
<div class="frm-slider-container">
<?php FrmAppHelper::icon_by_class( 'frmfont frm-margin-top' ); ?>
<input type="range" class="frm-slider" min="0" max="<?php echo (int) $component['max_value']; ?>" value="<?php echo esc_attr( $component['top']['value'] ); ?>" />
<?php $this->print_range_input( __( 'Top value', 'formidable' ), $component['top']['value'], $component['top']['unit'] ); ?>

@deepsource-io deepsource-io Bot Aug 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $this might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

Comment thread classes/views/styles/components/templates/slider.php
<div class="frm-slider-container">
<?php FrmAppHelper::icon_by_class( 'frmfont frm-margin-bottom' ); ?>
<input type="range" class="frm-slider" min="0" max="<?php echo (int) $component['max_value']; ?>" value="<?php echo esc_attr( $component['bottom']['value'] ); ?>" />
<?php $this->print_range_input( __( 'Bottom value', 'formidable' ), $component['bottom']['value'], $component['bottom']['unit'] ); ?>

@deepsource-io deepsource-io Bot Aug 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $this might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

Comment thread classes/views/styles/components/templates/slider.php
<div class="frm-slider-container">
<?php FrmAppHelper::icon_by_class( 'frmfont frm-margin-left-right' ); ?>
<input type="range" class="frm-slider" min="0" max="<?php echo (int) $component['max_value']; ?>" value="<?php echo esc_attr( $component['horizontal']['value'] ); ?>" />
<?php $this->print_range_input( __( 'Horizontal value', 'formidable' ), $component['horizontal']['value'], $component['horizontal']['unit'] ); ?>

@deepsource-io deepsource-io Bot Aug 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $this might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

Comment thread classes/views/styles/components/templates/slider.php
<div class="frm-slider-container">
<?php FrmAppHelper::icon_by_class( 'frmfont frm-margin-left' ); ?>
<input type="range" class="frm-slider" min="0" max="<?php echo (int) $component['max_value']; ?>" value="<?php echo esc_attr( $component['left']['value'] ); ?>" />
<?php $this->print_range_input( __( 'Left value', 'formidable' ), $component['left']['value'], $component['left']['unit'] ); ?>

@deepsource-io deepsource-io Bot Aug 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $this might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

Comment thread classes/views/styles/components/templates/slider.php
<div class="frm-slider-container">
<?php FrmAppHelper::icon_by_class( 'frmfont frm-margin-right' ); ?>
<input type="range" class="frm-slider" min="0" max="<?php echo (int) $component['max_value']; ?>" value="<?php echo esc_attr( $component['right']['value'] ); ?>" />
<?php $this->print_range_input( __( 'Right value', 'formidable' ), $component['right']['value'], $component['right']['unit'] ); ?>

@deepsource-io deepsource-io Bot Aug 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $this might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

Comment thread classes/views/styles/components/templates/slider.php
<?php FrmAppHelper::icon_by_class( $component['icon'] ); ?>
<?php endif; ?>
<input type="range" class="frm-slider" min="0" max="<?php echo (int) $component['max_value']; ?>" value="<?php echo esc_attr( $component['value_label'] ); ?>" />
<?php $this->print_range_input( __( 'Field value', 'formidable' ), $component['value_label'], $component['unit_measurement'] ); ?>

@deepsource-io deepsource-io Bot Aug 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $this might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

Comment thread classes/views/styles/components/templates/slider.php
<div class="frm-slider-container">
<?php FrmAppHelper::icon_by_class( 'frmfont frm-margin-top-bottom' ); ?>
<input type="range" class="frm-slider" min="0" max="<?php echo (int) $component['max_value']; ?>" value="<?php echo esc_attr( $component['value_label'] ); ?>" />
<?php $this->print_range_input( __( 'Field value', 'formidable' ), $component['value_label'], $component['unit_measurement'] ); ?>

@deepsource-io deepsource-io Bot Aug 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $this might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

Comment thread classes/views/styles/components/templates/slider.php
<?php FrmAppHelper::icon_by_class( 'frmfont frm-margin-' . $field['type'] ); ?>
<?php endif; ?>
<input type="range" class="frm-slider" min="0" max="<?php echo (int) $component['max_value']; ?>" value="<?php echo ! empty( $component['unit_measurement'] ) ? (int) $field['value'] : esc_attr( $field['value'] ); ?>" />
<?php $this->print_range_input( $this->get_label_for_type( $field['type'] ), $field['value'], $component['unit_measurement'] ); ?>

@deepsource-io deepsource-io Bot Aug 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $this might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

Comment thread classes/views/styles/components/templates/slider.php
</div>
<div class="frm-slider-value">
<input aria-label="<?php esc_attr_e( 'Field value', 'formidable' ); ?>" type="text" value="<?php echo ! empty( $component['unit_measurement'] ) ? (int) $field['value'] : esc_attr( $field['value'] ); ?>" />
<input aria-label="<?php echo esc_attr( $this->get_label_for_type( $field['type'] ) ); ?>" type="text" value="<?php echo ! empty( $component['unit_measurement'] ) ? (int) $field['value'] : esc_attr( $field['value'] ); ?>" />

@deepsource-io deepsource-io Bot Aug 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $this might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

@deepsource-io

deepsource-io Bot commented Aug 7, 2026 •
edited
Loading

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in 3e9d3f1...573b306 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

Important

Some issues found as part of this review are outside of the diff in this pull request and aren't shown in the inline review comments due to GitHub's API limitations. You can see those issues on the DeepSource dashboard.

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
PHP Aug 7, 2026 7:42p.m. Review ↗
JavaScript Aug 7, 2026 7:42p.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deepsource-io deepsource-io[bot] deepsource-io[bot] left review comments

Assignees

No one assigned

Labels

run analysis run tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Crabcyborg