fix(walletconnect): wire the projectId gate - #93
Merged
Conversation
_require_project_id shipped in lib.star but no handler called it — every route answered with no credential at all, unlike the real WC relay. All seven handlers now demand a projectId (body, query, or bearer); the engine test and VM suite send one, and the suite's gate probes assert the 401s. The sidecar deviation narrows to what remains true: any non-empty projectId passes (no registry check).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
_require_project_idhelper shipped in lib.star but no handler called it — every walletconnect route answered with no credential at all, unlike the real relay. All seven handlers now demand a projectId (body, query, or bearer). The engine test and the VM suite send one; the suite's gate markers now assert the 401s instead of documenting the unwired gate; the sidecar deviation narrows to the true remainder (any non-empty projectId passes, no registry check). One of the campaign's logged optional remainders, closed.