Port canonical coordinates to cloud - #143
Conversation
…coordinates Store placed items in canonical coordinates
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis change keeps strategy content in a canonical attack-side coordinate system while rendering either tactical perspective, migrates legacy defense pages before cloud upload, and retains the latest selected page side during overlapping cloud updates. Focused Flutter coverage verified final-side recovery across an in-flight request and restart, side-switch persistence and undo/redo preservation, defense-side drag round-trips, and pre-v97 Hive-to-cloud migration. No defects were reproduced on the PR head. Confidence Score: 5/5The verified coordinate, migration, and synchronization paths are safe to merge. Focused tests exercised every identified failure mode. The defense-side lineup drag regression fails on the parent commit and passes on this PR, while durable page updates and legacy upload migration passed controlled persistence scenarios. Files Needing Attention: No files require follow-up for the reviewed behavior. The real web rendering attempt produced a hidden page body, but Flutter widget and focused integration-style tests covered the affected interactions.
What T-Rex did
Reviews (2): Last reviewed commit: "fix: store lineup drags in canonical coo..." | Re-trigger Greptile |
|
Addressed both Defense-side saved-lineup drag findings in 2088895, with a widget test covering canonical storage and Attack re-rendering for the agent and ability. @greptileai |
Summary
mainwhile preserving the cloud branch's media sizing and collaboration pathsisAttackvalue, with no placed-element or undo/redo coordinate rewrites.icafiles to v97 before their first cloud uploadVerification
fvm flutter test --no-pub: 602 passed, 2 skippednpm run test:convex: 33 passedfvm flutter analyze --no-pub: no errors or warnings, 35 existing info-level lintsgit diff --check