v0.3.22: Derived plan assignees; tasks page layout tweak#25
Merged
Conversation
…table Plan-level assignees were a separately-maintained join table that nothing in the UI ever wrote to (create always sent an empty array, the edit sheet had no assignee field), so every plan created through the app was permanently stuck showing "Unassigned" despite the widget's query logic being correct. Rather than add an assignee picker, make assignees reflect reality: the unique set of users assigned to the plan's tasks. This can't drift from what's actually happening, and needs no extra UI to keep in sync. - getCodePlan/getCodePlans (lib/db/queries.ts) derive assigneeIds from task.assigneeId instead of joining code_plan_assignees. - Dropped the now-write-only assigneeIds param from createCodePlan/ updateCodePlan and syncPlanAssignees entirely (lib/db/mutations.ts). - Dropped the code_plan_assignees table (schema + migration, both dialects) and its now-dead references in seed-demo.ts and tests. - Also: moved the Tasks page's "New Task" button onto the same row as the list/board view switcher (was a separate row above, pushing the table down for no reason). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
code_plan_assignees— plan creation hardcoded an empty array and the edit sheet had no assignee field at all. Rather than add a picker, assignees now reflect reality: the unique set of users assigned to the plan's tasks (getCodePlan/getCodePlansderive fromtask.assigneeId). Dropped the now-unusedcode_plan_assigneestable and all its write-path plumbing, for both DB dialects (migration0010_drop_plan_assignees, applied locally).Tag
v0.3.22has been pushed with this changelog.Test plan
tests/lib/db/mutations.test.ts): derived assignees update correctly as tasks are assigned/unassigned across a plan, and a plan with no tasks has no assignees.tsc --noEmit: no new errors (only the two pre-existing, documented ones).🤖 Generated with Claude Code