test: fix the two suites failing on main - #3062
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
macOS Testshas been red on every push tomainsince #3044, andiOS Testswent red once on #3052. Both are test defects, not app defects.macOS:
No menu names itself with accessibilityLabelFailing on 9 consecutive
mainruns (35694031462 through 35812418402), always with one offender:TrailingPaneHeaderView.swift:107.#3044 named the trailing pane's ellipsis menu with
.accessibilityElement(children: .contain)followed by.accessibilityLabel. That is the only form that names a pull-down whose label draws only an icon: the label then names the container, not the menu.TrailingPaneSurfaceUITests.testTheInspectorMenuSwitchesTheRowToJSONasserts the name is "Inspector Options" and passes on CI (it read""on the runner before #3044).The static scanner in
MenuDisclosureIndicatorTestspredates that finding and flags any.accessibilityLabelin a menu's modifier chain. It now skips one that follows.accessibilityElement(children: .contain). A bare.accessibilityLabelon a menu is still flagged.A new fixture test pins both sides, so the exemption cannot quietly widen:
.accessibilityLabelalone is reported.accessibilityElement(children: .contain)first is notNegative control: with the exemption removed, the tree scan reports
TrailingPaneHeaderView.swift:107again and the fixture test fails.iOS:
A second question waits its turn instead of being refusedFailed on 35740949976 with
queue.current?.idequal to the second prompt's id.The test started both questions with
async let. Each child task hops to the main actor on its own, so nothing orders the twoaskcalls, and the second question can be queued first.ConnectionPromptQueueis FIFO by call order and a real connect attempt asks its questions one after another, so the product is right and the test's ordering was a race. The test now waits for the first question to be on screen before asking the second.Not changed
BackgroundReleaseCoordinatorTests.inFlightReleaseSurvivesForegroundBouncehit its one-minute limit once (35604565186), while every test in that run reported about 108s of wall time on a cloned simulator. Since fix(datagrid): the filter bar, the pane menu's name, and the three red suites on main #3044 moved the suite to one simulator, the whole suite finishes in 0.29s.Testing
ConnectionPromptQueueTestsrun 200 times on the iOS simulator: 200 repetitions (-test-iterations 200), 0 failures.swiftlint lint --stricton both files: 0 violations.