test: fix the two test files that stop the test target compiling on main - #3098
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainat 9d188f2 does not build its test target, so every open pull request's app tests fail before running a case. Two test files are wrong, and one app file, which #3093 already fixes.TableProTests/Models/FileTabExternalChangeTests.swift:146(fix(tabs): notice any change to or deletion of an open SQL file, and report a failed move to Trash #3088) callsFileTabBaseline.recordWrite(of:encoding:to:in:). The function has always beenrecordWrite(of:to:in:), and both app callers use that. The test writes UTF-8 and asserts nothing about encoding, so the call drops the argument.TableProTests/Plugins/OracleColumnStatementsTests.swift(fix(plugin-oracle): read column defaults in the Structure tab #3089) callsreplacingOccurrences(of:with:options:range:)without importing Foundation, whichMemberImportVisibilityrejects.The third break is in the app target:
MainSplitViewController+RecentTabs.swift(#3061) switches overtabTypewithout the.versionHistorycase #3076 added. #3093 fixes that, so it is not repeated here; merge both.Tests
With #3093's diff applied locally, and removed before committing: the whole
TableProTeststarget builds, andFileTabExternalChangeTests,SourceFileDiskChangeHandlingTestsandOracleColumnStatementsTestspass, 33 of 33. SwiftLint on both files: 0 violations.