test: move the materialized view Quick Switcher tests onto the frecency key API - #3100
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maindoes not build its test target again. #3082 replacedQuickSwitcherItem(id:)andtableItemIdwith a frecency key, and added aconnectionSwitchesDatabases:argument tomakeCrossConnectionItems. #3063 and #3072 merged afterwards with tests written against the old API:TableProTests/Views/QuickSwitcherObjectKindTests.swift(feat(datagrid): show whether a materialized view can be refreshed concurrently, and gate its structure edits by kind #3063): builds items withid: QuickSwitcherItem.tableItemId(...)and callsmakeCrossConnectionItemswithout the new argument.TableProTests/Views/Main/MaterializedViewRowWriteTests.swift(fix(datagrid): open materialized views read-only in the data grid #3072): callsmakeCrossConnectionItemswithout the new argument.Both now use
QuickSwitcherFrecencyKey.table(name:schema:in:)and passconnectionSwitchesDatabases: true, which is what a PostgreSQL connection reports. Neither test asserts anything about the key, so their assertions are unchanged.Tests
The whole
TableProTeststarget builds.MaterializedViewRowWriteTestsandQuickSwitcherObjectKindTests: 14 of 14. SwiftLint on both files: 0 violations.