Fixes and improvements by KenVanHoeylandt · Pull Request #617 · TactilityProject/Tactility

KenVanHoeylandt · 2026-08-19T20:41:39Z

Summary by CodeRabbit

New Features
- Apps can be fully uninstalled, including running instances and installed files.
- AppHub accurately shows installation status and offers updates for newer versions.
- Application events use a consistent public identifier type.
Improvements
- App and service data, settings, screenshots, provisioning files, and preferences use a unified storage location.
- App and service asset paths resolve more consistently.
- Recursive app removal handles installed files and symbolic links more reliably.
Breaking Changes
- Legacy timezone C APIs have been removed.
- Public data-path helpers have been renamed.

It's not super consistent yet, but I'll fix that later

coderabbitai · 2026-08-19T20:42:36Z

Warning

Review limit reached

@KenVanHoeylandt, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 18 minutes

Limit details: You’ve used all 4 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3fc7347f-328f-417b-8b1b-a21032822f9c

📥 Commits

Reviewing files that changed from the base of the PR and between e95e090 and 60b7d4b.

📒 Files selected for processing (1)

Tactility/Source/app/setup/Setup.cpp

📝 Walkthrough

Walkthrough

The public path API now uses data-path terminology, and storage consumers use data-based or app-specific locations. Scanned applications can be uninstalled with recursive filesystem deletion and registry cleanup. ESP32 and POSIX modules register drivers through Module::drivers. App event APIs use AppInstanceId. Timezone C APIs are removed from the export table. The network task stack size and related documentation are updated.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 9.09% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The title is related to the changes but is too broad to identify the primary fixes, including path API changes, app uninstallation, and driver registration updates.	Replace the generic title with a concise summary of the main change, such as "Refactor data paths and app installation cleanup".

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 7

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

TactilityKernel/include/tactility/paths.h (1)
13-20: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Update the public API documentation.

The comment still describes a user-data root. paths_get_data_path returns the data path. Update the brief to use data-path terminology.
Proposed fix
- * `@brief` Get the root path for user data. Survives OS upgrades.
+ * `@brief` Get the data path. Survives OS upgrades.

🧹 Nitpick comments (1)

Modules/app-module/include/app/event.h (1)

57-59: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Propagate AppInstanceId through the caller boundary.

AppInstanceId is a uint32_t typedef, so existing raw-ID callers still compile. Tactility/Source/app/apphubdetails/AppHubDetailsApp.cpp still stores the identifier as uint32_t in Context, appMain, and start(). Use AppInstanceId at those boundaries so the API migration remains consistent and future representation changes do not leave raw-ID consumers behind. (raw.githubusercontent.com)

Also applies to: 94-94

Source: MCP tools

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 61c09ca7-0c48-4308-9147-6e67c7cfcc6f

📥 Commits

Reviewing files that changed from the base of the PR and between b03759a and 5ff98ab.

📒 Files selected for processing (36)

Buildscripts/sdkconfig/default.properties
Documentation/ideas.md
Modules/app-module/include/app/event.h
Modules/app-module/include/app/manager.h
Modules/app-module/private/app/private/app_fs.h
Modules/app-module/source/app_install.cpp
Modules/app-module/source/app_paths.cpp
Modules/app-module/source/event.cpp
Modules/app-module/source/manager.cpp
Modules/app-module/source/symbols.cpp
Modules/service-module/source/paths.cpp
Platforms/platform-esp32/source/module.cpp
Platforms/platform-posix/source/module.cpp
Tactility/Include/Tactility/DeprecatedPaths.h
Tactility/Source/DeprecatedPaths.cpp
Tactility/Source/Tactility.cpp
Tactility/Source/app/apphubdetails/AppHubDetailsApp.cpp
Tactility/Source/app/i2cscanner/I2cScanner.cpp
Tactility/Source/app/setup/Setup.cpp
Tactility/Source/bluetooth/BluetoothPairedDevice.cpp
Tactility/Source/bluetooth/BluetoothSettings.cpp
Tactility/Source/network/Ntp.cpp
Tactility/Source/service/webserver/WebServerService.cpp
Tactility/Source/service/wifi/WifiBootSplashInit.cpp
Tactility/Source/settings/AudioSettings.cpp
Tactility/Source/settings/BootSettings.cpp
Tactility/Source/settings/KeyboardSettings.cpp
Tactility/Source/settings/SystemSettings.cpp
Tactility/Source/settings/TouchCalibrationSettings.cpp
Tactility/Source/settings/time.cpp
TactilityC/Include/tt_time.h
TactilityC/Source/tt_init.cpp
TactilityC/Source/tt_time.cpp
TactilityKernel/include/tactility/paths.h
TactilityKernel/source/paths.cpp
TactilityKernel/source/symbols.c

💤 Files with no reviewable changes (3)

TactilityC/Source/tt_time.cpp
TactilityC/Source/tt_init.cpp
TactilityC/Include/tt_time.h

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.

coderabbitai

Actionable comments posted: 1

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 99d2cd38-052b-496d-a615-f45551619a5e

📥 Commits

Reviewing files that changed from the base of the PR and between 5ff98ab and 5cc815e.

📒 Files selected for processing (2)

Modules/service-module/tests/source/service_paths_test.cpp
TactilityKernel/tests/source/paths_test.cpp

Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.

To avoid recursive directory creation

coderabbitai

Actionable comments posted: 2

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5c765544-c962-4dd8-9bab-c8783256fd5e

📥 Commits

Reviewing files that changed from the base of the PR and between 5cc815e and e95e090.

📒 Files selected for processing (4)

Modules/app-module/private/app/private/app_fs.h
Modules/app-module/source/manager.cpp
Modules/service-module/tests/source/service_paths_test.cpp
Tactility/Source/settings/AudioSettings.cpp

Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review.

KenVanHoeylandt added 8 commits August 18, 2026 21:48

Move driver listing to Module definition

9299df0

Delete tt_time from TactilityKernel

bede5f2

Use AppInstanceId instead of int

3275629

Update ideas.md for subscription changes

222bd2a

Fix for app uninstall

b93acb1

Fix for callstack issue when downloading app in App Hub

45c796c

Fixes for paths

ef4d0c6

App path updates and fixes

5ff98ab

It's not super consistent yet, but I'll fix that later

Fix for paths test

5cc815e

coderabbitai Bot reviewed Aug 19, 2026

View reviewed changes

Comment thread Modules/service-module/tests/source/service_paths_test.cpp

KenVanHoeylandt added 4 commits August 19, 2026 23:08

Fix for PC build

5d89d40

Fixes

8b4124d

Invert logic

e95e090

Revert setup path

60b7d4b

To avoid recursive directory creation

coderabbitai Bot reviewed Aug 19, 2026

View reviewed changes

Comment thread Modules/app-module/private/app/private/app_fs.h

Comment thread Modules/app-module/source/manager.cpp

Navigation Menu

Uh oh!

Uh oh!

Fixes and improvements - #617

Fixes and improvements#617
KenVanHoeylandt wants to merge 13 commits into
mainfrom
develop

KenVanHoeylandt commented Aug 19, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Aug 19, 2026 •

edited

Loading

Review limit reached

Walkthrough

❌ Failed checks (1 warning, 1 inconclusive)

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Uh oh!

Conversation

KenVanHoeylandt commented Aug 19, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Aug 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Walkthrough

❌ Failed checks (1 warning, 1 inconclusive)

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

KenVanHoeylandt commented Aug 19, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Aug 19, 2026 •

edited

Loading