Fix shadcn reference accessibility and pinned example drift #152
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,7 +13,7 @@ | |
| "geometry": [ | ||
| { | ||
| "role": "bar", | ||
| "count": 1, | ||
| "rendererRoles": { | ||
| "recharts": "arc", | ||
| "tanstack": "arc" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,102 @@ | ||
| import { describe, expect, it } from 'vitest' | ||
| import { act } from 'react' | ||
| import { createShadcnRechartsExample } from './shadcn-catalog-recharts' | ||
| import { getShadcnCatalogSpec, shadcnColors } from './shadcn-catalog-data' | ||
|
|
||
| describe('shadcn reference accessibility', () => { | ||
| it.each([ | ||
| ['chart-radial-text', '200'], | ||
| ['chart-radial-shape', '1,260'], | ||
| ])( | ||
| 'preserves the pinned single-Safari radial example: %s', | ||
| async (name, value) => { | ||
| const root = document.createElement('div') | ||
| document.body.append(root) | ||
| const handle = await act(async () => | ||
| createShadcnRechartsExample(name).mount(root, { | ||
| width: 640, | ||
| height: 600, | ||
| revision: 0, | ||
| }), | ||
| ) | ||
| try { | ||
| const values = root.querySelectorAll( | ||
| 'path.recharts-radial-bar-sector, .recharts-radial-bar-sector path', | ||
| ) | ||
| expect(values).toHaveLength(1) | ||
| expect(values[0]?.getAttribute('fill')).toBe(shadcnColors[1]) | ||
| expect( | ||
| [...root.querySelectorAll('svg text')].map( | ||
| (text) => text.textContent, | ||
| ), | ||
| ).toContain(value) | ||
| expect( | ||
| root.querySelectorAll('circle.sc-radial-value-grid'), | ||
| ).toHaveLength(2) | ||
| } finally { | ||
| await act(async () => handle.destroy()) | ||
| root.remove() | ||
| } | ||
| }, | ||
| ) | ||
| it('uses the pinned custom bar paint and both label placements', async () => { | ||
| const root = document.createElement('div') | ||
| document.body.append(root) | ||
| const handle = await act(async () => | ||
| createShadcnRechartsExample('chart-bar-label-custom').mount(root, { | ||
| width: 640, | ||
| height: 600, | ||
| revision: 0, | ||
| }), | ||
| ) | ||
| try { | ||
| const bars = root.querySelectorAll('.recharts-bar-rectangle path') | ||
| expect(bars).toHaveLength(6) | ||
| expect( | ||
| [...bars].every((bar) => bar.getAttribute('fill') === shadcnColors[1]), | ||
| ).toBe(true) | ||
| const labels = [...root.querySelectorAll('.recharts-label')].map( | ||
| (label) => label.textContent, | ||
| ) | ||
| expect(labels).toHaveLength(12) | ||
| expect(labels).toContain('January') | ||
| expect(labels).toContain('186') | ||
|
Comment on lines
+58
to
+63
There was a problem hiding this comment. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win Assert the relative label positions. The 🤖 Prompt for AI Agents |
||
| } finally { | ||
| await act(async () => handle.destroy()) | ||
| root.remove() | ||
| } | ||
| }) | ||
| it.each([ | ||
| 'chart-area-linear', | ||
| 'chart-bar-label-custom', | ||
| 'chart-bar-default', | ||
| 'chart-line-dots', | ||
| 'chart-pie-donut', | ||
| 'chart-radar-grid-none', | ||
| 'chart-radial-text', | ||
| 'chart-tooltip-label-custom', | ||
| ])('names the rendered chart on mount and update: %s', async (name) => { | ||
| const root = document.createElement('div') | ||
| document.body.append(root) | ||
| const input = { width: 640, height: 600, revision: 0 } | ||
| const handle = await act(async () => | ||
| createShadcnRechartsExample(name).mount(root, input), | ||
| ) | ||
| try { | ||
| for (const revision of [0, 1]) { | ||
| if (revision) | ||
| await act(async () => | ||
| handle.update({ ...input, revision, width: 320 }), | ||
| ) | ||
| const charts = root.querySelectorAll('svg[aria-label]') | ||
| expect(charts).toHaveLength(1) | ||
| expect(charts[0]?.getAttribute('aria-label')).toBe( | ||
| getShadcnCatalogSpec(name).title, | ||
| ) | ||
| } | ||
| } finally { | ||
| await act(async () => handle.destroy()) | ||
| root.remove() | ||
| } | ||
| }) | ||
| }) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Add
Classification: toolingto F-274.The follow-up records additional tooling friction.
Owner: Toolingdoes not satisfy the required classification field.🤖 Prompt for AI Agents