Skip to content

docs(solid-query): replace the 'advanced-ssr' placeholder with a pointer to the SSR guide - #11588

Merged
sukvvon merged 1 commit into
mainfrom
docs/solid-advanced-ssr-placeholder
Sep 23, 2026
Merged

sukvvon merged 1 commit into
mainfrom
docs/solid-advanced-ssr-placeholder

Conversation

@sukvvon

@sukvvon sukvvon commented Sep 23, 2026 •

Copy link
Copy Markdown
Member

🎯 Changes

Replaces the Will come soon placeholder in docs/framework/solid/guides/advanced-ssr.md with a one-line pointer to the SSR guide.

vue/svelte/preact/angular/lit don't have an advanced-ssr.md guide at all — only react does, since it covers React Server Components and the Next.js app router, concepts specific to that ecosystem. Solid's placeholder traces back to #8950, which scaffolded the full set of react guide filenames for solid-query in bulk; advanced-ssr.md was copied along without content ever being written for it.

I looked for solid-query-specific SSR material that could fill this page (checked notifyManager batching, the reconcile/structuralSharing option, and the solid-start-streaming example's /hydration route that compares query state across server/hydration/client). Everything either turned out not to be SSR-specific or was already covered by the SSR guide (#11581), so there's no separate "advanced" API surface to document — this page now says so and points to the guide that has it all.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
  • I fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

  • Documentation
    • Clarified that Solid Query’s server-rendering guide covers hydration for both basic and advanced use cases, with useQuery hydrating automatically wherever it is used.

@coderabbitai

coderabbitai Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: TanStack/query/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: f0a94bec-0ce9-43f5-990e-8667a4255f18

📥 Commits

Reviewing files that changed from the base of the PR and between 848b421 and f8c820e.

📒 Files selected for processing (1)
  • docs/framework/solid/guides/advanced-ssr.md

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The Advanced Server Rendering guide replaces its placeholder with a description of Solid Query hydration. It states that useQuery hydrates automatically wherever it is used.

Changes

Solid SSR documentation

Layer / File(s) Summary
Document Solid Query hydration
docs/framework/solid/guides/advanced-ssr.md
The guide states that Solid Query does not distinguish basic from advanced server rendering. It also states that useQuery hydrates automatically wherever it is used, with no additional API surface beyond the SSR guide.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to f8c82

The updated page directs readers to the SSR guide, which explains Solid Query hydration. No merge-blocking documentation issue is evident.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the documentation change: replacing the Solid Query advanced SSR placeholder with a pointer to the SSR guide.
Description check ✅ Passed The description explains the change and motivation, documents the investigation, completes the checklist, and identifies the change as documentation-only with no release impact.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit f8c820e

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 2m 57s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-09-23 05:50:06 UTC

@sukvvon sukvvon self-assigned this Sep 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

@pkg-pr-new

pkg-pr-new Bot commented Sep 23, 2026

Copy link
Copy Markdown
More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@11588

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@11588

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@11588

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@11588

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@11588

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@11588

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@11588

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@11588

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@11588

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@11588

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@11588

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@11588

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@11588

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@11588

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@11588

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@11588

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@11588

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@11588

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@11588

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@11588

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@11588

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@11588

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@11588

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@11588

commit: f8c820e

@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
react full 11.87 KB (0%)
react minimal 8.85 KB (0%)

@sukvvon
sukvvon merged commit 1b7250b into main Sep 23, 2026
9 checks passed
@sukvvon
sukvvon deleted the docs/solid-advanced-ssr-placeholder branch September 23, 2026 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant