fix(router-core): preserve encoded slashes in splat params#7893
Open
xianjianlf2 wants to merge 1 commit into
Open
fix(router-core): preserve encoded slashes in splat params#7893xianjianlf2 wants to merge 1 commit into
xianjianlf2 wants to merge 1 commit into
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughSplat parameter decoding now preserves encoded slashes within segments while decoding other characters. Wildcard and fuzzy catch-all extraction use the new behavior, with tests covering both matching modes. ChangesSplat parameter decoding
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7871.
Splat params span multiple path segments, so decoding the whole splat with
decodeURIComponentmakes an encoded slash inside a segment indistinguishable from a real path separator.This decodes splat params segment-by-segment and keeps
%2Fencoded inside each segment. Other encoded characters in the segment, like%20,%23, and%3D, are still decoded as before. The same helper is used for fuzzy**params.Tests:
pnpm --dir packages/router-core test:unit --run tests/path.test.tspnpm --dir packages/router-core test:eslintpnpm --dir packages/history build && pnpm --dir packages/router-core test:types:ts70Summary by CodeRabbit