Skip to content

Canonicalize Markdown docs to HTML and return real 404s - #1265

Open
tannerlinsley wants to merge 2 commits into
taren/local-docs-directory-bridgefrom
taren/docs-markdown-canonical
Open

tannerlinsley wants to merge 2 commits into
taren/local-docs-directory-bridgefrom
taren/docs-markdown-canonical

Conversation

@tannerlinsley

Copy link
Copy Markdown
Member

Give Markdown documentation responses an absolute HTTP Link canonical pointing to the corresponding HTML page. Reuse the existing latest-document lookup and canonical URL builder, including current-version aliases. Preserve Markdown content, filtering options, and permanent moved-page redirects.

Also return explicit HTTP 404 responses for unknown documents and libraries. Throwing Router notFound from these server handlers produced a 200 response in the HTTP regression check. Error responses do not advertise a canonical.

Based on #1263 for the local directory bridge used in verification. Merge that prerequisite, then retarget this PR to main.

Validation: HTTP checks matched Markdown headers to HTML canonicals for framework and generic routes, current-version aliases, moved Solid tutorial URLs with query options, and missing documents/libraries. Final commit checks passed:516 tests,3 skips, types and lint clean. No claim of archived-branch coverage from local files. Guidance: https://developers.google.com/search/docs/crawling-indexing/consolidate-duplicate-urls#rel-canonical-header

@coderabbitai

coderabbitai Bot commented Sep 12, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: efe4ff01-26b1-4f8c-bdc3-db395d75138c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 12, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
tanstack-com 393bbb1 Commit Preview URL

Branch Preview URL
Sep 12 2026, 12:24 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant