feat(navigation): add route defined tabs - #1272
harry-whorlow wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe change adds custom tool tab definitions and route metadata. Library navigation and layout logic now use library-aware custom targets and route-provided tab settings. Charts-specific menu handling is removed, and related navigation tests use the updated signatures. ChangesCustom library tool tabs
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Feature Sequence Diagram(s)sequenceDiagram
participant RouteStaticData
participant LibraryLayout
participant customToolTabs
participant NavigationLink
RouteStaticData->>LibraryLayout: Provide docsTab metadata
LibraryLayout->>customToolTabs: Check library and target
customToolTabs-->>LibraryLayout: Return custom target status
LibraryLayout->>NavigationLink: Configure origin and preload behavior
Suggested reviewers: Merge Risk: ⚪ Minimal · up to Custom tabs, active-tab selection, and full-bleed route settings are aligned, with no established merge-blocking behavior. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2a43601 to
65fb2a3
Compare
Summary by CodeRabbit