fix(docs): Allow square brackets in repo paths for dynamic routes - #1273
Open
sentry[bot] wants to merge 2 commits into
Open
sentry[bot] wants to merge 2 commits into
sentry[bot] wants to merge 2 commits into
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
tanstack-com | 7f96347 | Commit Preview URL Branch Preview URL |
Sep 14 2026, 11:05 PM |
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where SvelteKit and Next.js dynamic route filenames, which use square brackets (e.g.,
[postId]), were being rejected by theisValidRepoPathvalidation.The
REPO_PATH_SEGMENT_PATTERNregex insrc/utils/repo-path.tsdid not include[or], leading to a validation error when the example viewer attempted to load source files likeexamples/svelte/ssr/src/routes/[postId]/+page.svelte.Changes Made:
REPO_PATH_SEGMENT_PATTERNinsrc/utils/repo-path.tsto include[and]characters.tests/repo-path.test.tsto specifically validate paths containing square-bracket segments, ensuring the fix works as expected and preventing regressions.This change is safe as existing path traversal defenses remain intact, and it aligns with the precedent of allowing other special characters like
$in repo paths.Fixes TANSTACK-COM-2Q9
This PR was automatically generated by Sentry. You can adjust this setting at any time.