Secure or update sta latest 06/30#4335
Conversation
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
…ROAD-flow-scripts
…ROAD-flow-scripts
…ROAD-flow-scripts
…ROAD-flow-scripts
…ROAD-flow-scripts
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
…ROAD-flow-scripts
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the OpenROAD submodule and modifies the save_images.tcl script to use the extracted scene_name instead of the scene object when naming saved layout images. The reviewer noted that saving the clock tree image to cts_$clock_name.webp will overwrite the image for each scene when multiple scenes exist, and suggested incorporating ${scene_name} into that filename as well to prevent overwriting.
| $::env(REPORTS_DIR)/cts_$clock_name.webp | ||
| gui::select_clockviewer_clock $clock_name | ||
| save_image -resolution $resolution $::env(REPORTS_DIR)/cts_${scene}_${clock_name}_layout.webp | ||
| save_image -resolution $resolution $::env(REPORTS_DIR)/cts_${scene_name}_${clock_name}_layout.webp |
There was a problem hiding this comment.
When there are multiple scenes, saving the clock tree image to $::env(REPORTS_DIR)/cts_$clock_name.webp (on line 73) will overwrite the image for each scene, leaving only the last scene's image. Since you are already extracting scene_name and using it for the layout image on line 75, you should also update the clock tree image filename on line 73 to include ${scene_name} (e.g., cts_${scene_name}_$clock_name.webp) to prevent overwriting.
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
|
I didn't see any QoR change in the secure CI runs https://jenkins.openroad.tools/view/all/job/OpenROAD-flow-scripts-Private/job/secure-or_update_sta_latest_0629/ |
2 participants
Update OpenSTA to 6/30th latest has some metrics variation (minor), Also mode and scene are now TCL object and not string so some save GIU scripts need updation too