ci: set frontend coverage baseline below the observed floor - #60
Merged
Conversation
The gate compared against 18.5% statements / 32.59% branches / 26.43% lines, which the suite does not reproducibly meet. Identical code reports 960/5191 statements on some machines and 965-966/5191 on others, so runs failed or passed depending on which runner picked up the job rather than on any change to the code. Lower the floor below the low end of that band, record the band in the baseline file, and document the gate in DEVELOPMENT.md. Coverage itself is unchanged; this only stops false failures. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ci/check-frontend-coverage.mjscompared against 18.5% statements / 32.59% branches / 26.43% lines. The suite does not reproducibly meet those numbers: identical code reports 960/5191 statements on some machines (18.49% / 32.55% / 26.4%) and 965-966/5191 on others (18.58-18.6% / 32.87-32.99% / 26.46%).The result was CI failing or passing based on which runner picked up the job. Three PRs in the last day failed this gate without touching any frontend code, then passed unchanged on re-run.
Change
docs/DEVELOPMENT.mdCoverage itself is unchanged —
next_statement_target(25) andlong_term_statement_target(60) are untouched, so the ratchet still works as intended.Follow-up not included here
The underlying spread is a handful of statements that are covered only sometimes, most likely async continuations that race process teardown. Making those tests deterministic is worth doing separately; it is not a prerequisite for a gate that stops firing falsely.
Validation
npm test -- --coverage --coverage-reporters=text-summary --coverage-reporters=json-summary(88 tests pass, 960/5191 statements)node ci/check-frontend-coverage.mjs ...→frontend coverage meets baseline: statements 18.49%, branches 32.55%, functions 34.7%, lines 26.4%🤖 Generated with Claude Code