feat(frame-pacer): overhaul logic and render FPS limits and presets - #2699
Open
githubawn wants to merge 6 commits into
Open
feat(frame-pacer): overhaul logic and render FPS limits and presets#2699githubawn wants to merge 6 commits into
githubawn wants to merge 6 commits into
Conversation
|
| Filename | Overview |
|---|---|
| Core/GameEngine/Include/Common/FrameRateLimit.h | Replaces fixed logic-rate bounds and steps with preset-based APIs that accept an optional snap value. |
| Core/GameEngine/Source/Common/FramePacer.cpp | Ensures network sessions render at no less than the fixed simulation frame rate. |
| Core/GameEngine/Source/Common/FrameRateLimit.cpp | Adds render and logic presets, documents their ascending-order invariant, and implements nearest-preset traversal. |
| Core/GameEngine/Source/GameClient/MessageStream/CommandXlat.cpp | Updates logic-time-scale commands to snap against render FPS and retain the last enabled logic rate. |
Reviews (4): Last reviewed commit: "Fix review comments: simplify UncappedFp..." | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Skyaero42
requested changes
May 12, 2026
xezon
reviewed
May 28, 2026
xezon
left a comment
xezon
left a comment
There was a problem hiding this comment.
My review is incomplete.
This change conflicts a bit with a change I have in the works where logic step can run faster than render update. I can only continue it after the particle decoupling.
This change should wait.
githubawn
marked this pull request as draft
June 27, 2026 18:45
- Added 15 FPS to render presets and expanded logic presets (1 to 960 FPS). - Implemented array-based preset snapping for logic FPS. - Renamed extraStep to snapValue for clarity. - Removed redundant logic speed scaling guards and safety asserts. - Cleaned up stale comments and dead code in CommandXlat.
githubawn
force-pushed
the
feature/frame-pacer-overhaul
branch
from
July 31, 2026 21:11
36bfef6 to
0e498df
Compare
githubawn
marked this pull request as ready for review
July 31, 2026 21:11
Author
|
This PR is great for testing decoupling and interpolation. I found some microstutter using the 1 fps logic rate and it saves running OBS to see the frame by frame stuff. |
Skyaero42
reviewed
Aug 2, 2026
Skyaero42
reviewed
Aug 2, 2026
| { | ||
| prevValue = fpsValue; | ||
| } | ||
| break; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change was generated with AI assistance. All generated code has been reviewed, tested, and verified for functionality.