Skip to content

feat(headless): stub gogoMessageBox in GameWindowManagerDummy #2894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bobtista wants to merge 2 commits into from
Closed

feat(headless): stub gogoMessageBox in GameWindowManagerDummy #2894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6bdaf3c
feat(headless): stub gogoMessageBox in GameWindowManagerDummy
bobtista Jul 19, 2026
7e9370d
feat(headless): replicate gogoMessageBox stub to Generals
bobtista Jul 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions Generals/Code/GameEngine/Include/GameClient/GameWindowManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,6 +389,16 @@ class GameWindowManagerDummy : public GameWindowManager

virtual GameWindow *allocateNewWindow() override { return newInstance(GameWindowDummy); }

// TheSuperHackers @fix bobtista 19/07/2026 Return no message box window in headless mode
virtual GameWindow *gogoMessageBox(Int x, Int y, Int width, Int height, UnsignedShort buttonFlags,
UnicodeString titleString, UnicodeString bodyString,
GameWinMsgBoxFunc yesCallback, GameWinMsgBoxFunc noCallback,
GameWinMsgBoxFunc okCallback, GameWinMsgBoxFunc cancelCallback) override { return nullptr; }
virtual GameWindow *gogoMessageBox(Int x, Int y, Int width, Int height, UnsignedShort buttonFlags,
UnicodeString titleString, UnicodeString bodyString,
GameWinMsgBoxFunc yesCallback, GameWinMsgBoxFunc noCallback,
GameWinMsgBoxFunc okCallback, GameWinMsgBoxFunc cancelCallback, Bool useLogo) override { return nullptr; }

virtual GameWinDrawFunc getPushButtonImageDrawFunc() override { return nullptr; }
virtual GameWinDrawFunc getPushButtonDrawFunc() override { return nullptr; }
virtual GameWinDrawFunc getCheckBoxImageDrawFunc() override { return nullptr; }
Expand Down
10 changes: 10 additions & 0 deletions GeneralsMD/Code/GameEngine/Include/GameClient/GameWindowManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,6 +389,16 @@ class GameWindowManagerDummy : public GameWindowManager

virtual GameWindow *allocateNewWindow() override { return newInstance(GameWindowDummy); }

// TheSuperHackers @fix bobtista 19/07/2026 Return no message box window in headless mode
virtual GameWindow *gogoMessageBox(Int x, Int y, Int width, Int height, UnsignedShort buttonFlags,
UnicodeString titleString, UnicodeString bodyString,
GameWinMsgBoxFunc yesCallback, GameWinMsgBoxFunc noCallback,
GameWinMsgBoxFunc okCallback, GameWinMsgBoxFunc cancelCallback) override { return nullptr; }
virtual GameWindow *gogoMessageBox(Int x, Int y, Int width, Int height, UnsignedShort buttonFlags,
UnicodeString titleString, UnicodeString bodyString,
GameWinMsgBoxFunc yesCallback, GameWinMsgBoxFunc noCallback,
GameWinMsgBoxFunc okCallback, GameWinMsgBoxFunc cancelCallback, Bool useLogo) override { return nullptr; }

virtual GameWinDrawFunc getPushButtonImageDrawFunc() override { return nullptr; }
virtual GameWinDrawFunc getPushButtonDrawFunc() override { return nullptr; }
virtual GameWinDrawFunc getCheckBoxImageDrawFunc() override { return nullptr; }
Expand Down
Loading