unify(win32device): Move Win32Device to Core - #3046
Open
Jaredl-Dev wants to merge 2 commits into
Open
Conversation
Skyaero42
requested changes
Aug 2, 2026
Skyaero42
left a comment
There was a problem hiding this comment.
If there are difference between the files (except for the header line), there needs to be a merge before a move.
- Use one commit to merge the files.
- Use a second commit to move the files.
This allows us the clearly review which code snippets are merged an how.
Alternatively:
- Create a PR to merge the files
- Create a PR to move the files.
Look at some of the other merge/move PR's how its done
Jaredl-Dev
force-pushed
the
unify/win32device
branch
from
August 2, 2026 15:05
fc8acd1 to
152d8db
Compare
Author
I have updated this PR. |
xezon
approved these changes
Aug 2, 2026
xezon
left a comment
There was a problem hiding this comment.
Looks correct. Pull id's are missing in commit titles.
Author
|
Both commit titles now include (#3046). |
Jaredl-Dev
force-pushed
the
unify/win32device
branch
from
August 2, 2026 21:03
152d8db to
2f1409b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the remaining shared Win32Device files into Core:
Win32GameEngine.hWin32GameEngine.cppWin32OSDisplay.cppGenerals and Zero Hour differ only by product-name comments, a documentation typo, and an Alt-Tab audio refresh.
Generals gets:
Verification