Fix detector training with AMP enabled - #219
Open
sopenlaz0 wants to merge 1 commit into
Open
Conversation
sopenlaz0
marked this pull request as ready for review
August 7, 2026 05:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Initialize
Trainer.use_transformerstoFalsein the detector model setup and add a focused detector-AMP training regression test.Root cause
The AMP training branch checks
self.use_transformersbefore choosing the model call signature. Recognition setup initializes that attribute, but detector setup did not, so detector training withGlobal.use_amp: trueraisedAttributeErrorbefore its first forward pass.Detection models always use the standard
model(image, data=...)path, so setting the flag toFalsein_init_det_modelmakes that contract explicit.Validation
pytest -q tests/test_detector_amp.py— 1 passedThe regression test initializes the detector builders and executes one AMP optimizer step through
Trainer.train; it fails on the previous code at the undefined attribute and passes with this fix.