docs: demonstrate W_pos migration - #1572
Conversation
|
The full-coverage job's only failure is an unrelated flaky numerical-tolerance assertion in tests/unit/test_direct_path_patching.py after 6,597 tests passed. This PR only changes docs/source/content/migrating_to_v3.md. I don't have permission to rerun the workflow; could a maintainer please rerun the failed job? |
|
The failing Full Code Coverage job appears unrelated to this docs-only change. It completed 6,597 tests and failed only I reproduced that exact test on the current PR head It also passes under Python 3.13 locally. The PR changes only I do not have upstream workflow rerun permission. Could a maintainer rerun the failed Full Code Coverage job for this exact head? |
|
@lntutor I am rerunning it now sorry just getting to your comments! Lots of contributions to go through this morning. This specific CI test has been producing sporadic failures lately, it is a known issue that I have not gotten around to addressing. Thank you for the specific details about the failing test, I have noted this PR down in my notes for this problem and will come back here to reference it when I get around to fixing it! |
|
Flaky test is still failing, so I am pushing a fix to |
Description
Adds a runnable GPT-2 migration example for the
HookedTransformer.W_posandHookedTransformer.W_E_posmappings. The example:bridge.pos_embed.W_posW_E_posfrombridge.W_EandW_posThe accompanying explanation also points readers back to the existing numerical-matching guidance and mentions the raw/no-processing alternative.
Fixes #1560
Type of change
Verification
make formattorch.testing.assert_closecomparisons passuv run build-docs(build succeeded, 4 warnings; all four are pre-existing optional-import/duplicate-object warnings)git diff --checkChecklist
Not applicable: code comments and new automated tests, because this is a documentation-only runnable example.