fix(model_bridge): raise clear TypeError for non-bridge config in boot_native (#1562) - #1586
Closed
MeiSiristhebest wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Hey @MeiSiristhebest, I appreciate you taking a look at this, unfortunately this issue has already been resolved by #1573, and I forgot to close out the issue. Feel free to tackle any other issues that interest you, and please make sure to take note on where the PR should base. This fix was specifically intended for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1562. boot_native raised an opaque AttributeError for non-bridge configs; now raises a clear TypeError.