refactor(train): relocate to tools/training.py for bridge compatibility - #1594
Open
MdSadiqMd wants to merge 2 commits into
Open
refactor(train): relocate to tools/training.py for bridge compatibility#1594MdSadiqMd wants to merge 2 commits into
MdSadiqMd wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Relocate
train()+HookedTransformerTrainConfigfromtransformer_lens/train.pytotransformer_lens/tools/training.py, typed againstnn.ModulesoTransformerBridgetrains through it.Motivation:
train.py:17hard-importsHookedTransformerand is re-exported from__init__.py:10, so at 4.0 the package import breaks unless the loop leaves the HT namespace.Changes:
transformer_lens/tools/training.py: New home forTrainConfig(renamed fromHookedTransformerTrainConfig) andtrain(), typed againstnn.Moduletransformer_lens/train.py: Deprecation shim withDeprecationWarningon usetransformer_lens/tools/__init__.py: Addtrainingto lazy submodulestests/integration/model_bridge/test_native_training.py: Addtest_train_loop_trains_bridge_via_train_config, fixInductionDatasetto return single samplesAcceptance:
tools/training.pyexists, noHookedTransformerimportTransformerBridge(viaboot_native) trains throughtrain()from transformer_lens import trainstill imports, emitsDeprecationWarning, delegatestests/integration/model_bridge/test_native_training.pymake unit-test+uv run mypy .cleanFixes #1589
Type of change
Screenshots
N/A
Checklist: