Conversation
hfjelstad
marked this pull request as ready for review
September 24, 2026 07:58
Contributor
|
@hfjelstad, could you help me with the following steps?
Then, @thbar and I will handle the backport to As it was a previously approved change, I consider it being a missing part of the release v2.0.0 |
hfjelstad
force-pushed
the
restore_foldingSeat
branch
from
September 28, 2026 12:16
7597fde to
cac1a85
Compare
Contributor
Author
|
Ok now @TuThoThai ? |
TuThoThai
approved these changes
Sep 28, 2026
TuThoThai
left a comment
TuThoThai
left a comment
Contributor
There was a problem hiding this comment.
Perfect, thanks for this @hfjelstad!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-add
foldingSeattoAccommodationFacilityEnumerationThe
foldingSeatvalue appears to be missing in the v2.x line, even though it was reviewed and accepted earlier via #228This PR restores the single enumeration value in
xsd/netex_framework/netex_reusableComponents/netex_facility_support.xsd,inserting
foldingSeatright afterseating, matching the original change in #228.